Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo3 v 12 Compatibility #32

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

mrwhy-orig
Copy link

Changes made to support Typo3 V12 LTS

@RTPAst
Copy link

RTPAst commented Aug 21, 2023

The whole thing looks pretty good already, in the following files the ObjectManager is used, this is deprecated in TYPO3 V12:

  • Classes/Resource/Rendering/VimeoRenderer.php
  • Classes/Resource/Rendering/YouTubeRenderer.php

Delete the line with ObjectManager and replace $objectManager->get( with GeneralUtility::makeInstance(.

And in the composer.json file, the TYPO3 V12 version is missing in the required value ;).

@RTPAst
Copy link

RTPAst commented Sep 6, 2023

The following class also has a mistake

Classes/Resource/Rendering/VimeoRenderer.php
the replace param data-name="youtube" ... must replace with data-name="vimeo" ...

@RazielleS
Copy link

I would like to use this extension in TYPO3 12.
Since there seems not much progress in a while, would it be possible to just merge this PR and fix whatever is missing after basic v12 support is merged?

@RazielleS
Copy link

I have done some changes on https://github.com/RazielleS/we_cookie_consent/tree/v12 to change the data-name and remove the remaining ObjectManager calls.
It is based on this existing PR. Could this be added to this existing PR?
Otherwise I can create my own PR, so everything can be merged in one go.

V12 Compatibility, also changed data-name to vimeo
Typo3 v12 compatibillity
Typo3 v12 compatibillity, other versions not tested.
@mrwhy-orig
Copy link
Author

Ok @RazielleS I updated the PR.

Thanks @RTPAst & @RazielleS for looking into it and updating.

@RTPAst
Copy link

RTPAst commented Nov 10, 2023

Is there any news? We already have this in productive use with the changes described above and in my opinion everything works.

@mrwhy-orig
Copy link
Author

I do have it in productive use as well...

@ghermens
Copy link

I am currently testing this patch set for productive use.
There is a problem with the cookie list plugin, which still relies on switchable controller actions.
I made a pull request to mrwhy-orig/we_cookie_consent to keep everything in one place: mrwhy-orig#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants