Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sticky actions in navigator #4818

Merged
merged 4 commits into from
Feb 3, 2025
Merged

feat: Sticky actions in navigator #4818

merged 4 commits into from
Feb 3, 2025

Conversation

kof
Copy link
Member

@kof kof commented Feb 1, 2025

Description

https://share.descript.com/view/spOG60yRmmg

Actions in navigator now always visible even when horizontal scroll is involved

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from johnsicili February 1, 2025 12:44
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JYFI in Safari it does this. No need to fix

Screenshot 2025-02-02 at 11 02 27 AM Screenshot 2025-02-02 at 11 02 19 AM

@kof
Copy link
Member Author

kof commented Feb 3, 2025

@johnsicili weird on my safari version its fine

@kof kof merged commit a9180f7 into main Feb 3, 2025
17 checks passed
@kof kof deleted the sticky-actions branch February 3, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants