-
Notifications
You must be signed in to change notification settings - Fork 6
Add Drop Updates button to simulate transport failing to deliver messages #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jackaperkins
wants to merge
4
commits into
webxdc:main
Choose a base branch
from
jackaperkins:drop-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
70dd6af
Add a drop updates button per instance for testing eventual consistency
jackaperkins 174fd9e
swap dropUpdates envelop icon for Wifi/offline icons
jackaperkins 126d356
add mention of drop Updates feature to readme
jackaperkins 51351c6
explain quirk around drop updates feature and replaying of messages
jackaperkins File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -17,12 +17,27 @@ export class DevServerTransport implements Transport { | |||||||||||||||||||||||||
| messageListener: SocketMessageListener | null = null; | ||||||||||||||||||||||||||
| promise: Promise<Info>; | ||||||||||||||||||||||||||
| resolveInfo!: (info: Info) => void; | ||||||||||||||||||||||||||
| dropUpdates: boolean = false; | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| constructor(url: string) { | ||||||||||||||||||||||||||
| this.socket = new WebSocket(url); | ||||||||||||||||||||||||||
| this.promise = new Promise((resolve) => { | ||||||||||||||||||||||||||
| this.resolveInfo = resolve; | ||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||
| window.addEventListener("message", (event) => { | ||||||||||||||||||||||||||
| const isAllowed = | ||||||||||||||||||||||||||
| event.origin.includes("localhost:") || | ||||||||||||||||||||||||||
| (location.host.endsWith(".webcontainer.io") && | ||||||||||||||||||||||||||
| event.origin.includes(".webcontainer.io")); | ||||||||||||||||||||||||||
| if (!isAllowed) { | ||||||||||||||||||||||||||
| return; | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
Comment on lines
+28
to
+34
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be nice not to copy-paste this code, especially if it's security-related Lines 136 to 147 in f2d1f43
|
||||||||||||||||||||||||||
| if (typeof event.data === 'object') { | ||||||||||||||||||||||||||
| if (event.data.name === 'dropUpdates') { | ||||||||||||||||||||||||||
| this.dropUpdates = event.data.value | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| }); | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| send(data: any): void { | ||||||||||||||||||||||||||
|
|
@@ -34,6 +49,9 @@ export class DevServerTransport implements Transport { | |||||||||||||||||||||||||
| this.socket.removeEventListener("message", this.messageListener); | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| const listener = (event: Event): void => { | ||||||||||||||||||||||||||
| if (this.dropUpdates) { | ||||||||||||||||||||||||||
| return | ||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||
| callback(JSON.parse((event as any).data)); | ||||||||||||||||||||||||||
| }; | ||||||||||||||||||||||||||
| this.messageListener = listener; | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not clear enough that this is just a quirk of the current simulator implementation.
and some typos: