Skip to content

fix(backend): add trailing slash to Gerrit account validation API #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ch15084 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(backend): add trailing slash to Gerrit account validation API #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/app/repository/gerrit_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -520,10 +520,10 @@ def validate_token(

try:
# Validate by getting account info
# GET /accounts/self
# GET /accounts/self/
response = self._make_request(
method="GET",
url=f"{api_base_url}/accounts/self",
url=f"{api_base_url}/accounts/self/",
username=user_name,
http_password=decrypt_token,
auth_type=auth_type,
Expand Down
6 changes: 3 additions & 3 deletions backend/tests/repository/test_gerrit_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def test_make_request_uses_digest_auth_by_default(self, gerrit_provider, mocker)

gerrit_provider._make_request(
method="GET",
url="https://gerrit.example.com/a/accounts/self",
url="https://gerrit.example.com/a/accounts/self/",
username="testuser",
http_password="testpassword",
# No auth_type specified - should default to digest
Expand All @@ -139,7 +139,7 @@ def test_make_request_uses_digest_auth_when_specified(

gerrit_provider._make_request(
method="GET",
url="https://gerrit.example.com/a/accounts/self",
url="https://gerrit.example.com/a/accounts/self/",
username="testuser",
http_password="testpassword",
auth_type="digest",
Expand All @@ -161,7 +161,7 @@ def test_make_request_uses_basic_auth_when_specified(self, gerrit_provider, mock

gerrit_provider._make_request(
method="GET",
url="https://gerrit.example.com/a/accounts/self",
url="https://gerrit.example.com/a/accounts/self/",
username="testuser",
http_password="testpassword",
auth_type="basic",
Expand Down