-
Notifications
You must be signed in to change notification settings - Fork 143
fix(wework): answer non-blocking Codex questions while the model runs #3762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sdadunderscoresdad
wants to merge
5
commits into
wecode-ai:main
Choose a base branch
from
sdadunderscoresdad:fix/wework-async-request-user-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1efeafc
fix(wework): answer non-blocking Codex questions while the model runs
sdadunderscoresdad c50d292
fix(ci): rebuild missing Wework desktop E2E runtimes
sdadunderscoresdad 87880bc
fix(ci): restore permissions on rebuilt desktop E2E runtimes
sdadunderscoresdad a83e87e
feat(wework): show the answered question on async question replies
sdadunderscoresdad 0c2fda2
fix(wework): preserve line breaks in async question replies
sdadunderscoresdad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,115 @@ | ||
| // SPDX-FileCopyrightText: 2026 Weibo, Inc. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| use serde_json::{json, Value}; | ||
|
|
||
| use super::util::string_field; | ||
|
|
||
| /// A `request_user_input_async` question: one prompt plus suggested answers. | ||
| /// | ||
| /// Codex uses the same shape in the live `agentMessage.questions` payload and in | ||
| /// the replayed `request_user_input_async` tool arguments, so both projections of | ||
| /// the interactive card normalize here. The answer to such a question is always | ||
| /// the next user message, never a runtime response. | ||
| pub(crate) fn async_question_render_payload(item_id: &str, questions: &[Value]) -> Option<Value> { | ||
| let questions = questions | ||
| .iter() | ||
| .enumerate() | ||
| .filter_map(|(index, question)| async_question(index, question)) | ||
| .collect::<Vec<_>>(); | ||
| if questions.is_empty() { | ||
| return None; | ||
| } | ||
| Some(json!({ | ||
| "kind": "request_user_input", | ||
| "delivery": "async", | ||
| "itemId": item_id, | ||
| "questions": questions, | ||
| })) | ||
| } | ||
|
|
||
| fn async_question(index: usize, question: &Value) -> Option<Value> { | ||
| let prompt = string_field(question, "title") | ||
| .or_else(|| string_field(question, "question")) | ||
| .unwrap_or_default() | ||
| .trim() | ||
| .to_owned(); | ||
| let options = question | ||
| .get("options") | ||
| .and_then(Value::as_array) | ||
| .into_iter() | ||
| .flatten() | ||
| .filter_map(option_label) | ||
| .collect::<Vec<_>>(); | ||
| if prompt.is_empty() && options.is_empty() { | ||
| return None; | ||
| } | ||
| Some(json!({ | ||
| "id": format!("question_{}", index + 1), | ||
| "question": prompt, | ||
| "options": options, | ||
| // Codex accepts a free-text answer next to the suggested options. | ||
| "is_other": true, | ||
| })) | ||
| } | ||
|
|
||
| fn option_label(option: &Value) -> Option<Value> { | ||
| let label = option | ||
| .as_str() | ||
| .map(str::to_owned) | ||
| .or_else(|| string_field(option, "label")) | ||
| .unwrap_or_default(); | ||
| let label = label.trim(); | ||
| (!label.is_empty()).then(|| json!({ "label": label })) | ||
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { | ||
| use super::*; | ||
|
|
||
| #[test] | ||
| fn normalizes_title_and_plain_string_options() { | ||
| let payload = async_question_render_payload( | ||
| "call-1", | ||
| &[json!({ | ||
| "title": "Which state jitters?", | ||
| "options": ["Following", "Reading", "Both"], | ||
| })], | ||
| ) | ||
| .expect("payload"); | ||
|
|
||
| assert_eq!(payload["kind"], "request_user_input"); | ||
| assert_eq!(payload["delivery"], "async"); | ||
| assert_eq!(payload["itemId"], "call-1"); | ||
| assert_eq!(payload["questions"][0]["id"], "question_1"); | ||
| assert_eq!(payload["questions"][0]["question"], "Which state jitters?"); | ||
| assert_eq!(payload["questions"][0]["is_other"], true); | ||
| assert_eq!(payload["questions"][0]["options"][0]["label"], "Following"); | ||
| assert_eq!(payload["questions"][0]["options"][2]["label"], "Both"); | ||
| } | ||
|
|
||
| #[test] | ||
| fn drops_blank_questions_and_blank_options() { | ||
| let payload = async_question_render_payload( | ||
| "call-2", | ||
| &[ | ||
| json!({"title": " "}), | ||
| json!({"title": "Pick one", "options": [" ", "Second"]}), | ||
| ], | ||
| ) | ||
| .expect("payload"); | ||
|
|
||
| let questions = payload["questions"].as_array().expect("questions"); | ||
| assert_eq!(questions.len(), 1); | ||
| assert_eq!(questions[0]["question"], "Pick one"); | ||
| assert_eq!(questions[0]["options"].as_array().map(Vec::len), Some(1)); | ||
| assert_eq!(questions[0]["options"][0]["label"], "Second"); | ||
| } | ||
|
|
||
| #[test] | ||
| fn rejects_questions_without_prompt_or_options() { | ||
| assert!(async_question_render_payload("call-3", &[json!({"title": ""})]).is_none()); | ||
| assert!(async_question_render_payload("call-4", &[]).is_none()); | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.