Skip to content

Add PHP 8.5 and Composer 2.9 support #146

Merged
gmazzap merged 17 commits intowecodemore:version-3from
Soean:php_8_5
Nov 28, 2025
Merged

Add PHP 8.5 and Composer 2.9 support #146
gmazzap merged 17 commits intowecodemore:version-3from
Soean:php_8_5

Conversation

@Soean
Copy link
Contributor

@Soean Soean commented Nov 25, 2025

Description

Adds PHP 8.5 and Composer 2.9 support

How has this been tested?

  • PHP 8.5 and Composer 2.9 were added to the github workflows tests.
  • Tested local.

Types of changes

src/Step/Steps.php
Fixes PHP 8.5 deprecation

Method SplObjectStorage::attach() is deprecated since 8.5, use method SplObjectStorage::offsetSet() instead, in wecodemore/wpstarter/src/Step/Steps.php line 109.

‎src/Util/DbChecker.php
Fixes PHPStan error

Left side of and is always false.
🪪 logicalAnd.leftAlwaysFalse

src/Util/Paths.php‎
Fixes PHPStan error / PHP 8.5 deprecation

Possibly invalid array key type string|null.

Deprecated: Using null as an array offset is deprecated, use an empty string instead

composer.json

  • Root composer.json requires composer/composer ~2.3.0, found composer/composer[2.3.0, ..., 2.3.10] but these were not loaded, because they are affected by security advisories. To ignore the advisories, add ("PKSA-b8f7-zn44-r4gz", "PKSA-s25b-vbmp-jvhh", "PKSA-jn72-4kr8-gj3h", "PKSA-m1ph-vmbx-2xd3") to the audit "ignore" config. To turn the feature off entirely, you can set "block-insecure" to false in your "audit" config.

Issues

Fixes #144

@Soean Soean marked this pull request as ready for review November 26, 2025 07:46
@gmazzap
Copy link
Member

gmazzap commented Nov 26, 2025

Just one thing, IIUC instead of blocking unsecure packages we could remove support for Composer 2.3, right?

@gmazzap
Copy link
Member

gmazzap commented Nov 26, 2025

Ah, and thank you fro your work @Soean!

@Soean
Copy link
Contributor Author

Soean commented Nov 26, 2025

It works with Composer >=2.7. So we have to remove Composer 2.3 - 2.6 support.

@gmazzap gmazzap merged commit 7634692 into wecodemore:version-3 Nov 28, 2025
22 checks passed
@Soean Soean deleted the php_8_5 branch November 28, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants