-
-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove flake8-executable dependency #1172
Comments
But, we only need a single violation for this. Let's call it |
I'd like to work on it ! |
🤝 thanks a lot! |
@pandaseal does this plugin work on Windows without building? |
Yes the plugin works.
However, the reason the build does not work on windows is the |
@pandaseal you would do us a big (like 2 years big) favour if you tackle this windows build issue down. I don't own a windows machine and too lazy to setup and an emulation, so this is an actual problem for us that is not solved for 2 years now. We can even bring back the windows CI with https://docs.travis-ci.com/user/reference/windows/ If you are willing to work on this, we can reopen #337 |
* Add ExecutableMismatchViolation #9 * Add logic for ExecutableMismatch * Add WPS452 to test_noqa.py #5 * Remove dependency and related test * Implement the full checking logic (#13) * Fix linting problem (#14) * Clean up code (#15) Fix checking logic so that we don't thoroughly check every comment * Fix permissions (#16) * Make a new visitor to handle files with 0 comments (#17) * Add tests for ExecutableMismatchViolation (#18) * Add ExecutableMismatchViolation #9 * Add WPS452 to test_noqa.py #5 * Remove dependency and related test * Add test resource files from flake8-executable * Add tests for check_valid_shebang #7 * Implement the full checking logic (#13) * Fix linting problem (#14) * Clean up code (#15) Fix checking logic so that we don't thoroughly check every comment * Fix permissions (#16) * Ignore failing test files * Update test file to be compatible with the new visitor * Fix linter issues * Make a new visitor to handle files with 0 comments (#17) * Exclude test files from linting Co-authored-by: Hanzhang <[email protected]> Co-authored-by: jrutqvist <[email protected]> Co-authored-by: Gabriel Chang <[email protected]> * Update CHANGELOG.md * Moved test resources to fixtures to be ignored by autopep8 * Add integration test * Refactor tests * Make the requested changes Use temporary files for testing * Update noqa.py * Make additional requested changes * Fix small formatting and typing issues * Update comments.py * Update comments.py Co-authored-by: hanzhsu <[email protected]> Co-authored-by: Gabriel Chang <[email protected]> Co-authored-by: Hanzhang <[email protected]> Co-authored-by: jrutqvist <[email protected]> Co-authored-by: Nikita Sobolev <[email protected]>
We need to vendor this dependency to our own codebase:
Implementation: https://github.com/xuhdev/flake8-executable/blob/abf67771703b2f06f02a3fedb1dd97299583a4c3/flake8_executable/__init__.py#L92-L128
Related: #1139
The text was updated successfully, but these errors were encountered: