Issue #1172 #1199
Merged
Issue #1172 #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ExecutableMismatchViolation and remove flake8-executable
Fix checking logic so that we don't thoroughly check every comment
* Add ExecutableMismatchViolation #9 * Add WPS452 to test_noqa.py #5 * Remove dependency and related test * Add test resource files from flake8-executable * Add tests for check_valid_shebang #7 * Implement the full checking logic (#13) * Fix linting problem (#14) * Clean up code (#15) Fix checking logic so that we don't thoroughly check every comment * Fix permissions (#16) * Ignore failing test files * Update test file to be compatible with the new visitor * Fix linter issues * Make a new visitor to handle files with 0 comments (#17) * Exclude test files from linting Co-authored-by: Hanzhang <[email protected]> Co-authored-by: jrutqvist <[email protected]> Co-authored-by: Gabriel Chang <[email protected]>
Pull Request Test Coverage Report for Build 2758
💛 - Coveralls |
sobolevn
requested changes
Feb 28, 2020
tests/fixtures/test_executable_mismatch_resources/exe001_neg.py
Outdated
Show resolved
Hide resolved
Use temporary files for testing
sobolevn
requested changes
Feb 29, 2020
tests/test_visitors/test_tokenize/test_comments/test_valid_shebang.py
Outdated
Show resolved
Hide resolved
tests/test_visitors/test_tokenize/test_comments/test_valid_shebang.py
Outdated
Show resolved
Hide resolved
tests/test_visitors/test_tokenize/test_comments/test_valid_shebang.py
Outdated
Show resolved
Hide resolved
adambenali
force-pushed
the
issue-#1172
branch
from
bcc8275 to
d9a3c5b
Compare
sobolevn
reviewed
Mar 1, 2020
sobolevn
approved these changes
Mar 1, 2020
|
Oh, I am merging this into @adambenali can you please rebase this PR or allow changes from maintainers? |
@sobolevn, edits from maintainers are already allowed. |
|
Strange. I still cannot fix conflicts. |
|
Oh sorry, It should work now, I've removed the protection from the branch ! |
sobolevn
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
We first wanted to use the existing
FileMagicCommentsVisitor, because it would make more sense as a shebang is also a magic comment. This wouldn't work however since we also need to check cases where there is no comment in the file. So we created a new visitor for this.The behavior is exactly the same as
flake8-executable.🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.