Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flake8-coding #1174

Closed
sobolevn opened this issue Feb 22, 2020 · 6 comments · Fixed by #1215
Closed

Remove flake8-coding #1174

sobolevn opened this issue Feb 22, 2020 · 6 comments · Fixed by #1215
Assignees
Labels
dependencies Pull requests that update a dependency file feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers pr-merged

Comments

@sobolevn
Copy link
Member

We need to vendor this dependency to our own codebase:

  • create new violation
  • create new logical check
  • write tests
  • copy configuration

Implementation: https://github.com/tk0miya/flake8-coding/blob/master/flake8_coding.py#L52-L73

Related: #1139

@sobolevn sobolevn added feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers dependencies Pull requests that update a dependency file labels Feb 22, 2020
@sobolevn sobolevn added this to the Version 0.14 aka python3.8 milestone Feb 22, 2020
@orsinium
Copy link
Collaborator

Is explicit encoding still actual? In Python 3 it's UTF-8 by default, and there is no reason to make it non-UTF.

The default encoding for Python source code is UTF-8

@sobolevn
Copy link
Member Author

I start to agree with this point. We can completely remove this plugin.

But, I am kind of used to this little line 😢
# -*- coding: utf-8 -*-

@orsinium
Copy link
Collaborator

We're just too old. Soon we'll be changed by the generation that has never seen Python 2 and hacks around encodings 😀

@Kvm99
Copy link
Contributor

Kvm99 commented Feb 28, 2020

Hi! Could I take the issue?

@sobolevn
Copy link
Member Author

Thanks a lot! Assigned.

@sobolevn
Copy link
Member Author

@Kvm99 we would also need to remove EmptyLineAfterCodingViolation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers pr-merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants