Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue-1174: Remove flake8-coding #1215

Merged
merged 12 commits into from
Mar 2, 2020
Merged

Issue-1174: Remove flake8-coding #1215

merged 12 commits into from
Mar 2, 2020

Conversation

Kvm99
Copy link
Contributor

@Kvm99 Kvm99 commented Feb 28, 2020 •
edited
Loading

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

@coveralls
Copy link

coveralls commented Feb 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 2724

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2722: 0.0%
Covered Lines: 5190
Relevant Lines: 5190
💛 - Coveralls

sobolevn
sobolevn requested changes Feb 28, 2020
View reviewed changes
@Kvm99 Kvm99 requested a review from sobolevn March 1, 2020 18:42
sobolevn
sobolevn approved these changes Mar 2, 2020
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Awesome work! 🥇

@sobolevn sobolevn merged commit 58b9621 into wemake-services:master Mar 2, 2020
@radzak
Copy link

radzak commented Apr 3, 2020

@sobolevn I believe these lines could also be removed from https://github.com/wemake-services/wemake-django-template right?

@sobolevn
Copy link
Member

sobolevn commented Apr 4, 2020

@radzak yes, please! Would you send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove flake8-coding
4 participants
@Kvm99 @coveralls @radzak @sobolevn