wemake-services · sobolevn · Mar 2, 2020 · Feb 28, 2020 · Feb 28, 2020 · Feb 28, 2020
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,10 @@ Semantic versioning in our case means:
 - Adds baseline information for all complexity violation messages: `x > baseline`
 - Changes how cognitive complexity is calculated
 - Adds support for positional arguments in different checks
+- Forbids to use `continue` and `break` in `finally`. It is a terrible practice, because
+  `finally` is implicitly called and can cause damage to logic with its implicitness.
+- Removes flake8-coding, all encoding strings, visitor and tests
+  for `EmptyLineAfterCodingViolation`
 
 ### Bugfixes
 

diff --git a/docs/conf.py b/docs/conf.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 #
 # Configuration file for the Sphinx documentation builder.
 #

diff --git a/pyproject.toml b/pyproject.toml
@@ -65,7 +65,6 @@ flake8-quotes = "^2.0.1"
 flake8-comprehensions = "^3.1.0"
 flake8-docstrings = "^1.3.1"
 flake8-string-format = "^0.2"
-flake8-coding = "^1.3"
 flake8-bugbear = "^19.3"
 flake8-pep3101 = "^1.2"
 flake8-debugger = "^3.1"

diff --git a/setup.cfg b/setup.cfg
@@ -16,7 +16,6 @@ statistics = False
 doctests = True
 
 # Plugins:
-accept-encodings = utf-8
 max-complexity = 6
 max-line-length = 80
 

diff --git a/styles/styleguide.toml b/styles/styleguide.toml
@@ -3,7 +3,6 @@ format = "wemake"
 show-source = true
 
 # Plugins:
-accept-encodings = "utf-8"
 max-line-length = 80
 max-complexity = 6
 

diff --git a/tests/conftest.py b/tests/conftest.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import os
 from collections import namedtuple
 

diff --git a/tests/fixtures/formatter/correct.py b/tests/fixtures/formatter/correct.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 Module level docstring.
 

diff --git a/tests/fixtures/noqa/noqa.py b/tests/fixtures/noqa/noqa.py
@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-  # noqa: WPS323
 """
 This file contains all possible violations.
 

diff --git a/tests/fixtures/noqa/noqa38.py b/tests/fixtures/noqa/noqa38.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 This file represents AST location changes in python3.8 and above.
 

diff --git a/tests/fixtures/noqa/noqa_controlled.py b/tests/fixtures/noqa/noqa_controlled.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 This file contains all violations which may be tweaked using
 `i_control_code` or `i_dont_control_code` options.

diff --git a/tests/fixtures/noqa/noqa_pre38.py b/tests/fixtures/noqa/noqa_pre38.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 This file represents how AST worked before python3.8 release.
 

diff --git a/tests/plugins/ast_tree.py b/tests/plugins/ast_tree.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import ast
 from textwrap import dedent
 

diff --git a/tests/plugins/async_sync.py b/tests/plugins/async_sync.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 

diff --git a/tests/plugins/tokenize_parser.py b/tests/plugins/tokenize_parser.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import io
 import tokenize
 from textwrap import dedent

diff --git a/tests/plugins/violations.py b/tests/plugins/violations.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import inspect
 from operator import attrgetter, itemgetter
 

diff --git a/tests/test_checker/test_exception_handling.py b/tests/test_checker/test_exception_handling.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import ast
 from contextlib import suppress
 

diff --git a/tests/test_checker/test_hypothesis.py b/tests/test_checker/test_hypothesis.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 Integration test that our linter does not break on different random programs.
 

diff --git a/tests/test_checker/test_invalid_options.py b/tests/test_checker/test_invalid_options.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import subprocess
 
 

diff --git a/tests/test_checker/test_module_names.py b/tests/test_checker/test_module_names.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import ast
 
 import pytest

diff --git a/tests/test_checker/test_noqa.py b/tests/test_checker/test_noqa.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 Integration tests definition.
 
@@ -130,7 +128,7 @@
     'WPS320': 2,
     'WPS321': 1,
     'WPS322': 1,
-    'WPS323': 1,
+    'WPS323': 0,  # violation is deprecated
     'WPS324': 1,
     'WPS325': 1,
     'WPS326': 1,

diff --git a/tests/test_checker/test_presets.py b/tests/test_checker/test_presets.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import importlib
 import inspect
 from importlib.machinery import SourceFileLoader

diff --git a/tests/test_formatter/snapshots/__init__.py b/tests/test_formatter/snapshots/__init__.py
@@ -1 +0,0 @@
-# -*- coding: utf-8 -*-

diff --git a/tests/test_formatter/test_formatter_output.py b/tests/test_formatter/test_formatter_output.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 We use direct string assertiong on the formatter.
 

diff --git a/tests/test_logic/test_complexity/test_cognitive/conftest.py b/tests/test_logic/test_complexity/test_cognitive/conftest.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 Fixtures to make testing cognitive complexity easy.
 

diff --git a/tests/test_logic/test_complexity/test_cognitive/test_cognitive_complexity.py b/tests/test_logic/test_complexity/test_cognitive/test_cognitive_complexity.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 Test to ensure that we count cognitive complexity correctly.
 

diff --git a/tests/test_options/conftest.py b/tests/test_options/conftest.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 from flake8.options.manager import OptionManager
 

diff --git a/tests/test_options/test_option_rules.py b/tests/test_options/test_option_rules.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 from wemake_python_styleguide.options import config
 
 

diff --git a/tests/test_options/test_option_values/test_i_control_code.py b/tests/test_options/test_option_values/test_i_control_code.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 This is a regression test for the argument parsing issue for boolean args.
 

diff --git a/tests/test_options/test_validate_domain_names_options.py b/tests/test_options/test_validate_domain_names_options.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.options.validation import (

diff --git a/tests/test_plugins.py b/tests/test_plugins.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 """
 These test ensures that each plugin is enabled and working.
 
@@ -14,7 +12,6 @@
 
 PLUGINS = (
     'B002',  # flake8-bugbear
-    'C101',  # flake8-coding
     'A001',  # flake8-builtins
     'C400',  # flake8-comprehensions
     'C819',  # flake8-commas

diff --git a/tests/test_regressions/test_regression112.py b/tests/test_regressions/test_regression112.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import ast
 
 from pyflakes.checker import Checker as PyFlakesChecker

diff --git a/tests/test_version.py b/tests/test_version.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import subprocess
 
 from wemake_python_styleguide.version import pkg_name, pkg_version

diff --git a/tests/test_violations/test_codes.py b/tests/test_violations/test_codes.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 
 def test_all_unique_violation_codes(all_violations):
     """Ensures that all violations have unique violation codes."""

diff --git a/tests/test_violations/test_definition_order.py b/tests/test_violations/test_definition_order.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import inspect
 import re
 

diff --git a/tests/test_violations/test_docs.py b/tests/test_violations/test_docs.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 from wemake_python_styleguide.options.config import Configuration
 
 

diff --git a/tests/test_violations/test_implementation.py b/tests/test_violations/test_implementation.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import ast
 
 from wemake_python_styleguide.violations.base import ASTViolation

diff --git a/tests/test_visitors/conftest.py b/tests/test_visitors/conftest.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 from typing import Optional, Sequence
 
 import pytest

diff --git a/...isitors/test_ast/test_annotations/test_multiline_annotations/test_argument_annotations.py b/...isitors/test_ast/test_annotations/test_multiline_annotations/test_argument_annotations.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.visitors.ast.annotations import (

diff --git a/..._visitors/test_ast/test_annotations/test_multiline_annotations/test_return_annotations.py b/..._visitors/test_ast/test_annotations/test_multiline_annotations/test_return_annotations.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.visitors.ast.annotations import (

diff --git a/tests/test_visitors/test_ast/test_attributes/test_magic_attributes.py b/tests/test_visitors/test_ast/test_attributes/test_magic_attributes.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.oop import (

diff --git a/tests/test_visitors/test_ast/test_attributes/test_protected_attributes.py b/tests/test_visitors/test_ast/test_attributes/test_protected_attributes.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.visitors.ast.attributes import (

diff --git a/tests/test_visitors/test_ast/test_blocks/conftest.py b/tests/test_visitors/test_ast/test_blocks/conftest.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 # Assigns:

diff --git a/tests/test_visitors/test_ast/test_blocks/test_control_variables.py b/tests/test_visitors/test_ast/test_blocks/test_control_variables.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_outer_scope_shadow.py b/tests/test_visitors/test_ast/test_blocks/test_outer_scope_shadow.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_blocks_overlap.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_blocks_overlap.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_class_block.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_class_block.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_function_block.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_function_block.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_import_block.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_import_block.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_loop_blocks.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_loop_blocks.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_same_name.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_same_name.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_try_block.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_try_block.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_blocks/test_overlap/test_with_block.py b/tests/test_visitors/test_ast/test_blocks/test_overlap/test_with_block.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_builtins/test_assign/test_multiple_assign.py b/tests/test_visitors/test_ast/test_builtins/test_assign/test_multiple_assign.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_builtins/test_assign/test_unpacking_rules.py b/tests/test_visitors/test_ast/test_builtins/test_assign/test_unpacking_rules.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_builtins/test_collection_hashes/test_float_keys.py b/tests/test_visitors/test_ast/test_builtins/test_collection_hashes/test_float_keys.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_builtins/test_collection_hashes/test_hash_elements.py b/tests/test_visitors/test_ast/test_builtins/test_collection_hashes/test_hash_elements.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_builtins/test_collection_hashes/test_hash_hashable.py b/tests/test_visitors/test_ast/test_builtins/test_collection_hashes/test_hash_hashable.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_builtins/test_numbers/test_approximate_constants.py b/tests/test_visitors/test_ast/test_builtins/test_numbers/test_approximate_constants.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.best_practices import (

diff --git a/tests/test_visitors/test_ast/test_builtins/test_numbers/test_magic_numbers.py b/tests/test_visitors/test_ast/test_builtins/test_numbers/test_magic_numbers.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.constants import MAGIC_NUMBERS_WHITELIST

diff --git a/tests/test_visitors/test_ast/test_builtins/test_strings/test_alphabet_string.py b/tests/test_visitors/test_ast/test_builtins/test_strings/test_alphabet_string.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import string
 
 import pytest

diff --git a/tests/test_visitors/test_ast/test_builtins/test_strings/test_formatted_string.py b/tests/test_visitors/test_ast/test_builtins/test_strings/test_formatted_string.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.consistency import (

diff --git a/tests/test_visitors/test_ast/test_classes/test_base_classes/test_base_builtin_classes.py b/tests/test_visitors/test_ast/test_classes/test_base_classes/test_base_builtin_classes.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 import pytest
 
 from wemake_python_styleguide.violations.oop import BuiltinSubclassViolation

diff --git a/...s/test_visitors/test_ast/test_classes/test_base_classes/test_base_exception_base_class.py b/...s/test_visitors/test_ast/test_classes/test_base_classes/test_base_exception_base_class.py
@@ -1,5 +1,3 @@
-# -*- coding: utf-8 -*-
-
 from wemake_python_styleguide.violations.best_practices import (
     BaseExceptionSubclassViolation,
 )
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,3 @@
		# -- coding: utf-8 --

		import pytest


Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,3 @@
		# -- coding: utf-8 --

		import subprocess


Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,3 @@
		# -- coding: utf-8 --

		from wemake_python_styleguide.options import config


Expand Down
Original file line number	Diff line number	Diff line change
		@@ -1,5 +1,3 @@
		# -- coding: utf-8 --

		from wemake_python_styleguide.options.config import Configuration


Expand Down