Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 3310 fix #3311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HighBornHoney
Copy link

The job is done. This simple code successfully fixes the issue. But, by the way, I'm not sure if a new test is required in this situation. Should I create one?

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please add a test case.

Copy link

codecov bot commented Feb 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (981d573) to head (ee24e0f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #3311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          357       357           
  Lines        11715     11715           
  Branches       802       802           
=========================================
  Hits         11715     11715           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants