docs: state that the buildx settings are ignored in BuildKit mode - #417
Closed
alexey-igrychev wants to merge 1 commit into
Closed
docs: state that the buildx settings are ignored in BuildKit mode#417alexey-igrychev wants to merge 1 commit into
alexey-igrychev wants to merge 1 commit into
Conversation
The buildkitd section says no builder is provisioned per build, but not what that means for the buildx driver settings documented right above it: with an address set they are silently without effect, which reads as a bug to anyone who configured a driver and sees it unused. Signed-off-by: Aleksei Igrychev <aleksei.igrychev@palark.com>
Member
Author
|
Closing this: the sentence mostly repeats what the same section already states two paragraphs above ("no builder is provisioned or removed per build"), and it would need rewriting the moment #412 makes the driver a The underlying problem is real, but documentation is the wrong tool for it — filed as a validation requirement instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildkitd section in QUICKSTART (en/ru) says no builder is provisioned per build, but not what that means for the
TRDL_BUILDX_DRIVERandTRDL_BUILDX_DRIVER_OPTS_*settings documented right above it: withbuildkitd_addressset they have no effect at all. One sentence in each locale, so a driver that is configured and then unused does not read as a bug.Note for #412: once the driver is settable through
configuretoo, this sentence has to name those fields as well.