-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pre-commit.ci] pre-commit autoupdate #130
Conversation
5a91579
to
8f091b8
Compare
8f091b8
to
d7534d9
Compare
@joshuadavidthomas we should either drop 3.8 support or add an exclude for your fancy bash script so that Django 5.1 isn't tested with 3.8 or 3.9 |
@jefftriplett IIRC, the main part of that happens in this function in the Lines 37 to 48 in f043992
That generates the matrix which the GHA takes and runs with. So just need to add an exception for 5.1 As far as dropping support, I'm not sure. From a high-level, "I am building a public package for others to use" perspective I like trying to support all the versions of Django that are currently supported (so 4.1, 5.0, and 5.1 at the moment) -- unless I am relying specifically on a feature from a new version. And with that I like trying to hew close to what Django supports for each version, which does include 3.8 and 3.9 for Django 4.1. Though truthfully, I haven't used 3.8 or 3.9 in who know's how long so maybe that's a fool's errand. Looking at pypistats.org, there are basically no 3.8 downloads and only a handful of 3.9, at least for the past 30 days. |
All good. I fiddled around with nox locally and I missed the 50 call. I might have gotten distracted by using |
updates: - [github.com/astral-sh/ruff-pre-commit: v0.6.4 → v0.6.8](astral-sh/ruff-pre-commit@v0.6.4...v0.6.8) - [github.com/abravalheri/validate-pyproject: v0.19 → v0.20.2](abravalheri/validate-pyproject@v0.19...v0.20.2)
d7534d9
to
8f748bd
Compare
updates: