Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump min Python version for main Django and add 5.2a1 #156

Merged
merged 1 commit into from
Jan 21, 2025
Merged

bump min Python version for main Django and add 5.2a1 #156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,13 @@
DJ42 = "4.2"
DJ50 = "5.0"
DJ51 = "5.1"
DJ52 = "5.2a1"
DJMAIN = "main"
DJMAIN_MIN_PY = PY310
DJMAIN_MIN_PY = PY312
DJ_VERSIONS = [DJ42, DJ50, DJ51, DJMAIN]
DJ_LTS = [DJ42]
DJ_LTS = [
version for version in DJ_VERSIONS if version.endswith(".2") and version != DJMAIN
]
DJ_DEFAULT = DJ_LTS[0]
DJ_LATEST = DJ_VERSIONS[-2]

Expand All @@ -38,17 +41,21 @@ def should_skip(python: str, django: str) -> bool:
"""Return True if the test should be skipped"""

if django == DJMAIN and version(python) < version(DJMAIN_MIN_PY):
# Django main requires Python 3.10+
# Django main requires Python 3.12+
return True

if django == DJ50 and version(python) < version(PY310):
# Django 5.0 requires Python 3.10+
if django == DJ52 and version(python) < version(PY310):
# Django 5.1 requires Python 3.10+
return True

if django == DJ51 and version(python) < version(PY310):
# Django 5.1 requires Python 3.10+
return True

if django == DJ50 and version(python) < version(PY310):
# Django 5.0 requires Python 3.10+
return True

return False


Expand Down
Loading