-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add signal
to EIP1193RequestOptions
#3840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited for this! Some random code style feedback.
Co-authored-by: tmm <[email protected]>
thanks—applied |
Happy to continue with the other Actions too. |
I took an initial stab at it. It's ok but having done it this way it might more sense to figure out all the changes required for an action and then go through each one and apply all the changes:
a couple others that I'm not sure about but seemed useful:
|
Not to bother, but could we update this branch from main and avoid it going stale? I've been watching this PR eagerly :) |
129b947
to
9ad3509
Compare
This PR address #1701. If the approach looks good I'll extrapolate to the rest of the actions where this makes sense.