-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new workflow to update homebrew formula on release #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cjappl Great stuff, thanks for checking this out!
@cjappl Thanks for the quick fixes. |
No, I could, but it's probably safer from a security side to have wfxr do it (just so I don't have to send one of my tokens in plaintext to him via email or similar). He is still the one that must update any secrets or other Settings of this project, as it's under his name. I would expect the commits likely end up under his user account in that case! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@cjappl BREW_TOKEN has been set.
Thanks @wfxr ! Will merge sometime tomorrow. |
@cjappl Did you merge into |
Whoa. No I did not. Thank you for catching..... Let me fix that |
* Add new homebrew workflow * Review comments * Review comments
Great catch @carlfriedrich . would you please review #342 and #340 to make sure they are both as you expect them to be? |
This workflow was found here:
https://github.com/dawidd6/action-homebrew-bump-formula
This should be very similar to our AUR workflow, which can be seen here:
forgit/.github/workflows/aur.yaml
Lines 1 to 20 in ab7400d
I am writing an email to @wfxr asking him to add a BREW_TOKEN to our secrets with the appropriate permissions so this can run :). This change should not be submitted until he has confirmed the BREW_TOKEN has been added to our secrets.