Fix: --date option in gbl can not be overridden anymore #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of the arguments passed to git blame in _forgit_blame_preview has been changed in bfffda6, putting --date=short as the last argument instead of the first. This caused it taking precedence of anything defined in $FORGIT_BLAME_GIT_OPTS. This commit restores the order of the arguments to what they were before bfffda6.
carlfriedrich
approved these changes
Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check list
Description
The order of the arguments passed to git blame in _forgit_blame_preview has been changed in bfffda6, putting
--date=shortas the last argument instead of the first. This caused it taking precedence of anything defined in $FORGIT_BLAME_GIT_OPTS. This PR restores the order of the arguments to what they were before bfffda6.Type of change
Test environment