Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disabling --graph with FORGIT_LOG_GRAPH_ENABLE=false in grc #387

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Allow disabling --graph with FORGIT_LOG_GRAPH_ENABLE=false in grc #387

merged 1 commit into from
Apr 26, 2024

Conversation

sandr01d
Copy link
Collaborator

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

We allow disabling the --graph option of git log when $FORGIT_LOG_GRAPH_ENABLE=false is set. This PR makes sure that this is also the case in _forgit_revert_commit that has been ignoring this until now.

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

@sandr01d sandr01d merged commit 2ae84d3 into wfxr:master Apr 26, 2024
4 checks passed
@sandr01d sandr01d deleted the grc-graph branch April 26, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfxr wfxr wfxr approved these changes

@carlfriedrich carlfriedrich carlfriedrich approved these changes

@cjappl cjappl Awaiting requested review from cjappl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandr01d @wfxr @carlfriedrich