Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: add an .editorconfig and apply it to the codebase #404

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Meta: add an .editorconfig and apply it to the codebase #404

merged 3 commits into from
Nov 6, 2024

Conversation

suft
Copy link
Contributor

@suft suft commented Nov 5, 2024 •
edited
Loading

Check list

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation

Description

  • Supoorted by many editors to maintain consistent coding style
  • For more information on .editorconfig check out https://editorconfig.org/

Closes #403

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change

Test environment

  • Shell
    • bash
    • zsh
    • fish
  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

sandr01d
sandr01d approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@sandr01d sandr01d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @suft

@carlfriedrich
Copy link
Collaborator

@suft Thanks a lot for your contribution. Very useful! I added another commit to the PR which applies the editorconfig to git-forgit.

If no objections come in, I will merge this tomorrow.

@carlfriedrich carlfriedrich changed the title meta: add an .editorconfig and fix indentation style meta: add an .editorconfig and apply it to the codebase Nov 5, 2024
@carlfriedrich carlfriedrich changed the title meta: add an .editorconfig and apply it to the codebase Meta: add an .editorconfig and apply it to the codebase Nov 5, 2024
@carlfriedrich carlfriedrich merged commit 7a40a11 into wfxr:master Nov 6, 2024
4 checks passed
@suft suft deleted the editorconfig branch November 10, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandr01d sandr01d sandr01d approved these changes

@carlfriedrich carlfriedrich carlfriedrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an .editorconfig file
3 participants
@suft @carlfriedrich @sandr01d