Add version key to config

whatuserever · Feb 15, 2025 · 304e55e · 304e55e
1 parent 101a1db
commit 304e55e
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 2 deletions.
diff --git a/packages/main/src/backend/commonTypes.ts b/packages/main/src/backend/commonTypes.ts
@@ -11,6 +11,7 @@ export type {
   Spreadsheet,
 } from './export/outputVendors/googleSheets/googleSheetsInternalAPI';
 export interface Config {
+  version: number;
   outputVendors: {
     [OutputVendorName.GOOGLE_SHEETS]?: GoogleSheetsConfig;
     [OutputVendorName.YNAB]?: YnabConfig;

diff --git a/packages/main/src/backend/configManager/configMigration/configMigrator.ts b/packages/main/src/backend/configManager/configMigration/configMigrator.ts
@@ -1,7 +1,7 @@
 import { z } from 'zod';
 import { type Config } from '../../commonTypes';
 import { isOriginalConfig } from './versions/original';
-import { v1ConfigSchema } from './versions/v1';
+import { migrateOriginalToV1, v1ConfigSchema } from './versions/v1';
 
 const latestConfigSchema = v1ConfigSchema;
 
@@ -13,7 +13,7 @@ export function migrateConfig(config: unknown): Config {
   let currentConfig = config;
   // original config does not have version key and must be handled separately
   if (isOriginalConfig(config)) {
-    return config as Config;
+    currentConfig = migrateOriginalToV1(config);
   }
   let currentVersion = getConfigVersion(currentConfig);
 

diff --git a/packages/main/src/backend/configManager/defaultConfig.ts b/packages/main/src/backend/configManager/defaultConfig.ts
@@ -1,6 +1,7 @@
 import { type Config } from '../commonTypes';
 
 const DEFAULT_CONFIG: Config = {
+  version: 1,
   scraping: {
     numDaysBack: 40,
     showBrowser: false,

diff --git a/packages/preload/src/commonTypes.ts b/packages/preload/src/commonTypes.ts
@@ -15,6 +15,7 @@ export enum OutputVendorName {
 }
 
 export interface Config {
+  version: number;
   outputVendors: {
     [OutputVendorName.GOOGLE_SHEETS]?: GoogleSheetsConfig;
     [OutputVendorName.YNAB]?: YnabConfig;

diff --git a/packages/renderer/src/store/Store.test.tsx b/packages/renderer/src/store/Store.test.tsx
@@ -99,6 +99,7 @@ describe('Store', () => {
 });
 
 export const dummyConfig: Config = {
+  version: 1,
   scraping: {
     numDaysBack: 40,
     showBrowser: false,

diff --git a/packages/renderer/src/types.tsx b/packages/renderer/src/types.tsx
@@ -17,6 +17,7 @@ export enum OutputVendorName {
 }
 
 export interface Config {
+  version: number;
   outputVendors: {
     [OutputVendorName.GOOGLE_SHEETS]?: GoogleSheetsConfig;
     [OutputVendorName.YNAB]?: YnabConfig;