Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split document destination for top-level and nested contexts. #819

Closed
wants to merge 1 commit into from
Closed

Split document destination for top-level and nested contexts. #819

wants to merge 1 commit into from

Conversation

mikewest
Copy link
Member

@mikewest mikewest commented Oct 26, 2018 •
edited by pr-preview bot
Loading

Partially addresses #755.

Preview | Diff

@mikewest mikewest mentioned this pull request Oct 26, 2018
Closed
@annevk
Copy link
Member

annevk commented Oct 29, 2018

This seems fine to me, provided other implementers are on board and there's some test.

@annevk annevk added needs implementer interest Moving the issue forward requires implementers to express interest needs tests Moving the issue forward requires someone to write tests labels Nov 16, 2018
@annevk annevk removed the needs implementer interest Moving the issue forward requires implementers to express interest label Apr 3, 2020
@annevk
Copy link
Member

annevk commented Apr 3, 2020

We no longer want this, right?

@mikewest
Copy link
Member Author

mikewest commented Apr 6, 2020

Correct, we ended up splitting the mode instead, into navigate and nested-navigate.

@mikewest mikewest closed this Apr 6, 2020
@mikewest mikewest deleted the nested branch April 6, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs tests Moving the issue forward requires someone to write tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikewest @annevk