Set popover invoker immediately after changing popover's visibility state to "showing" #9481
Conversation
…tate to "showing" See <#9383 (comment)>. Fixes #9383.
ghost
added
the
ghost
requested a review
from
|
Test-coverage: https://github.com/web-platform-tests/wpt/blob/b87174e39fd3a502910430752d7f9fce233b1b35/html/semantics/popovers/popover-invoker-reset.html violated an assertion before, now it doesn't anymore, see #9383 (comment). |
josepharhar
left a comment
josepharhar
left a comment
There was a problem hiding this comment.
This matches what I am implementing in chromium. Thanks for the PR!
|
Corresponding change is being merged in chromium: https://chromium-review.googlesource.com/c/chromium/src/+/4657399 |
|
This seems like a normative change which normally has a PR template. How can be sure implementations will align with this change? I guess there's already a test which contradicts the current specification? |
Yes, the current assertion in the spec about the invoker not being set will be hit. Presumably implementations have not added that assertion yet, because if they did, they would be hitting it without this PR |
@annevk: Yes, there's a test which currently violates an assertion, see #9383 (comment). |
2 participants
See
#9383 (comment).
Fixes #9383.
/popover.html ( diff )