Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Add a missing comma #206

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Editorial: Add a missing comma #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion notifications.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ interpreted as a language tag. Validity or well-formedness are not enforced. [[!

<ol>
<li><p>Wait for any <a for=/ lt=fetch>fetches</a> to complete and <var>notification</var>'s
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope of this PR: This effectively is await-ing the fetch steps in bad way; the fetch steps say the resources are set only when supported but here we are waiting for those resources to be set.

Is there a better wait to wait for a parallel task? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should probably set "image resource" either way (to a decoded resource or to failure or some such). And then we wait for it to not be in its initial state (null?).

<a for=notification>image resource</a> <a for=notification>icon resource</a>, and
<a for=notification>image resource</a>, <a for=notification>icon resource</a>, and
<a for=notification>badge resource</a> to be set (if any), as well as the
<a for=action>icon resources</a> for the <var>notification</var>'s <a for=notification>actions</a>
(if any).
Expand Down
Loading