Editorial: add "has showNotification() been successfully invoked" #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a concept needed for Declarative Web Push: see w3c/push-api#360 for context.
4 tasks
saschanaz
reviewed
Mar 3, 2025
| @@ -1098,6 +1104,10 @@ method steps are: | |||
|
|
|||
| <li><p>Run the <a for=/>notification show steps</a> for <var>notification</var>. | |||
|
|
|||
| <li><p>Set <var>notification</var>'s <a for=notification>service worker registration</a>'s | |||
| <a for="service worker registration">has <code>showNotification()</code> been successfully invoked</a> | |||
| to true. | |||
There was a problem hiding this comment.
Nothing sets it back to false, perhaps the push event handler should set it false in w3c/push-api#385?
There was a problem hiding this comment.
I also wonder what would happen if another push event is fired before the previous one finishes, because then this value would conflict. Perhaps we could have PushEvent.showNotification() (where the default arg is the DWP parse result) to make it per-event? 🤔
There was a problem hiding this comment.
Right, I was waiting to see if this approach (which also means you have to process pushes sequentially) works for everyone, but then nobody gave feedback for what felt like an eternity…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a concept needed for Declarative Web Push: see w3c/push-api#360 for context.
Preview | Diff