Add piping helpers for other specs #1113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Woah, I totally missed this. Sorry. |
ricea
approved these changes
Apr 5, 2021
index.bs
Outdated
|
|
||
| <div algorithm="ReadableStream pipe through"> | ||
| The result of a {{ReadableStream}} |readable| <dfn export for="ReadableStream" lt="pipe | ||
| through|piping through">piped through</dfn> a {{TransformStream}} |transform|, given an optional |
There was a problem hiding this comment.
Question: do we want to require a {{TransformStream}}, or would the [=transform stream=] concept be sufficient here?
There was a problem hiding this comment.
The latter would require doing JavaScript-observable Get()s, which introduces the possibility of sync exceptions. I think we should leave it as just TransformStream for now unless some spec comes along that needs the generic concept.
3 tasks
|
Given that you found several good nits last round and I just got my eyes dilated so can barely see what I'm typing, I'd appreciate another once-over from you before merging :) |
|
I took another look. Still lgtm! |
domenic
added
the
other spec interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/fetch#1199.
Preview | Diff