Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning on register_test/4 #192

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

sabiwara
Copy link

On Elixir's main branch, ExUnit.Properties emits deprecation warnings on ExUnit.Case.register_test/4:

Screenshot 2024-02-12 at 13 33 50

Since StreamData supports Elixir ~> 1.11 and register_test/6 is since: "1.10.0", we can fix it by replacingregister_test/4 by its implementation.

@coveralls
Copy link

Pull Request Test Coverage Report for Build bad0863495c0c76c98a2d6158740bf5590330455-PR-192

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.0%) to 93.639%

Files with Coverage Reduction New Missed Lines %
lib/stream_data.ex 4 93.44%
Totals Coverage Status
Change from base Build 83832e2259457bb36c4a2f0a321f4b83258f82e4: -1.0%
Covered Lines: 368
Relevant Lines: 393

💛 - Coveralls

@whatyouhide
Copy link
Owner

Oh sweet good catch @sabiwara! Thanks 💟

@whatyouhide whatyouhide merged commit 2dbcef1 into whatyouhide:main Feb 12, 2024
2 checks passed
@sabiwara sabiwara deleted the deprecations_1.17 branch May 25, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants