Skip to content

fix(BUG-921): fix region enum name #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix(BUG-921): fix region enum name #35

merged 1 commit into from
Apr 3, 2025

Conversation

peterfoldes
Copy link
Contributor

No description provided.

@notion-workspace Notion Workspace
Copy link

Misnamed variable in wherobots/db/region.py

Copilot
Copilot AI reviewed Apr 3, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug identified in BUG-921 by correcting the enum name for the EU AWS region.

  • Renames the incorrect enum member from AWS_EU_EAST_1 to AWS_EU_WEST_1 to match the region's value.

@ClayMav
Copy link
Member

ClayMav commented Apr 3, 2025

Is this not used anywhere?

@peterfoldes
Copy link
Contributor Author

Is this not used anywhere?

It's just passed around as enum. Or parsed as an enum. Or used as string from the enum. So not directly, no.

@peterfoldes peterfoldes merged commit 56bbb66 into main Apr 3, 2025
7 checks passed
@peterfoldes peterfoldes deleted the peter/region-fix branch April 3, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ClayMav ClayMav ClayMav approved these changes

@mpetazzoni mpetazzoni Awaiting requested review from mpetazzoni

@zongsizhang zongsizhang Awaiting requested review from zongsizhang

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterfoldes @ClayMav