Skip to content

Fix nested images on update #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
onemoreahmad wants to merge 2 commits into from
Closed

Fix nested images on update #41

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1ba01c
Fix nested images on update
Jul 8, 2019
2e9a15c
Fix nested images on update - added the missing 'return'
Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/Value/Resolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,22 @@ class Resolver implements ResolverInterface
*/
public function set($model, $attribute, $groups)
{
return $model->$attribute = $groups->map(function($group) {
$modelAttribute = $model->$attribute;
return $model->$attribute = $groups->map(function($group) use ($modelAttribute) {

// Merge old attributes with the new ones to avoid override File/ Image Fields when nested Images
if(isset($modelAttribute)){
foreach ($modelAttribute as $oldAttribute) {
if($oldAttribute['key'] == $group->key()) {
return [
'layout' => $group->name(),
'key' => $group->key(),
'attributes' => array_merge($oldAttribute['attributes'], $group->getAttributes())
];
}
}
}

return [
'layout' => $group->name(),
'key' => $group->key(),
Expand Down Expand Up @@ -66,4 +81,4 @@ protected function extractValueFromResource($resource, $attribute)
}, $value);
}

}
}