Support a branch in detached HEAD state#424
Merged
etagwerker merged 3 commits intowhitesmith:mainfrom Apr 29, 2023
Merged
Conversation
Fix issue whitesmith#346 This commit prevents `sh: 1: Syntax error: "(" unexpected` error and completes the run with compare mode successfully.
etagwerker
approved these changes
Mar 22, 2023
Collaborator
etagwerker
left a comment
etagwerker
left a comment
There was a problem hiding this comment.
@h-r-k-matsumoto I like this idea. Thank you! ❤️
This was referenced May 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would resolve issue #346
The code below has a problem if check out a branch in the state of
detached HEAD.https://github.com/whitesmith/rubycritic/blob/main/lib/rubycritic/source_control_systems/git.rb#L82-L85
Even in that case, it can be run successfully with this change.
Check list: