Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Romania localities #16

Merged
merged 14 commits into from
Jun 27, 2020
Merged

Update Romania localities #16

merged 14 commits into from
Jun 27, 2020

Conversation

stepps00
Copy link
Contributor

@stepps00 stepps00 commented Apr 27, 2020

Will fix whosonfirst-data/whosonfirst-data#1741

To do:

  • Import new borough records for Bucharest
  • Update existing locality records' properties, geometries, and concordances (storing alts as needed)
  • Import new locality records from source that are not already in WOF
  • Flag non-matching locality records in WOF with mz:hierarchy_label of 0
  • Run names script across the repo
  • Add localized labels to region records
  • Adjust lbl:bbox properties
  • Adjust wof:lang properties
  • Ensure src: and wof: geom_alt prop values are correct
  • Verify the coterminous, capital_of, and any curated properties are updated accordingly
  • PIP records
  • Validate geometries and properties

@stepps00 stepps00 changed the title Update Bucharest localities [WIP] Update Bucharest localities Apr 27, 2020
@stepps00
Copy link
Contributor Author

stepps00 commented Apr 27, 2020

Commit Notes:

  • 0fa45de: Adds new borough records in Bucharest
  • 3e49fa7: Deprecates and sets mz:is_current to 0 for non-matching, bunk locality polygons
  • 656648e: Flags non-matching, leftover locality points with mz:is_funky of 1 and mz:hierarchy_label of 0. Alternatively, these records could have been superseded into new neighbourhoods, but I was unable to verify most of these places are valid neighbourhoods or localities.
  • 8d92696: Adds new locality records from the source that do not match to an existing WOF record
  • b11a76e: Updates locality records in cases when a single WOF record matches to a single source record. The matched record received new properties/concordances/geometries from the source match. When possible, non-Mapshaper centroids were preserved.
  • 103c349: Updates locality records in cases when two WOF records match to a single source record. Supersedes one WOF record into one "current" record. The "current" record received new properties/concordances/geometries from the source match. When possible, non-Mapshaper centroids were preserved from the best candidate (making sure the retained centroid falls within the new geometry).
  • 44ac876: Updates locality records in cases when three WOF records match to a single source record. Supersedes two WOF records into one "current" record. The "current" record received new properties/concordances/geometries from the source match. When possible, non-Mapshaper centroids were preserved from the best candidate (making sure the retained centroid falls within the new geometry).
  • f4e5047: Fixes an issue with single WOF <> source locality matches... b11a76e should have updated mapshaper and label centroids for some new geometries, but didn't. This commits updates those centroids (and centroid source).
  • f85581c: Adds new name translations (name: properties) to records in this repo using a modified version of the wiki names add script. Statistics/more info per language here.
  • 4e095e2: Removes lbl:bbox properties from records with non-Point geometries.
  • 09c5bda: Removes deprecated wof:lang properties, adding wof:lang_x_spoken and wof:lang_x_official properties to all current records.
  • 4995384: Validates geometries and properties
  • 71682a1: PIP work for branch

@stepps00 stepps00 changed the title [WIP] Update Bucharest localities [WIP] Update Romania localities Apr 30, 2020
@stepps00
Copy link
Contributor Author

stepps00 commented May 1, 2020

@nvkelso - this PR is ready for review. Once approved, I will wrap up the remaining items listed in this comment.

@stepps00 stepps00 requested a review from nvkelso May 1, 2020 21:44
@stepps00 stepps00 self-assigned this May 1, 2020
@stepps00
Copy link
Contributor Author

stepps00 commented May 4, 2020

I'm running the wiki names script across this repo now.

@stepps00
Copy link
Contributor Author

stepps00 commented May 4, 2020

lang count
ace 11
afr 5
aka 2
als 2
ang 1
ara 80
arg 8
arz 3648
asm 1
ast 4
azb 11
aze 20
bak 1
ban 2
bar 5
bcl 1
bel 12
ben 4
bos 5
bre 3
bul 37
cat 21
ceb 545
ces 66
che 8
chv 1
chy 1
ckb 2
crh 3
dan 14
deu 627
deu_at 24
deu_ch 27
diq 1
ell 11
eng_ca 48
eng_gb 50
epo 417
est 22
eus 1163
fas 80
fin 23
fra 222
frr 1
fry 1
gag 1
gcr 1
gla 2
gle 7
glg 9
heb 38
hin 4
hrv 38
hsb 1
hun 382
hye 22
ido 10
iku 1
ile 1
ind 47
isl 2
ita 628
jpn 26
kan 7
kat 11
kaz 4
kor 12
kur 3
lat 35
lav 12
lij 1
lim 1
lit 16
ltz 1
mal 2
mar 1
mdf 2
min 24
mkd 47
mlg 2
msa 181
mwl 1
nah 1
nds 52
new 1
nld 371
nno 15
nor 13
nov 2
nqo 1
nrm 8
oci 3
ori 1
oss 1
pan 1
pli 1
pms 1
pnb 6
pol 133
por 451
por_br 50
pus 3
que 1
rmy 7
ron 151
rue 3
rus 123
sah 2
sat 2
scn 1
sco 11
slk 17
slv 9
snd 2
spa 81
sqi 35
srp 503
srp_ec 86
srp_el 107
swa 2
swe 42
szl 4
szy 1
tam 1
tat 10
tel 1
tgk 47
tgl 3
tha 11
tur 19
twi 1
ukr 481
urd 16
uzb 19
vie 476
vol 437
war 6
wln 1
wuu 12
xmf 2
zho 173
zho_cn 48
zho_hk 60
zho_sg 48
zho_tw 48

total names added: 13049

total updated features: 5974

@stepps00
Copy link
Contributor Author

@nvkelso - this is ready for another look. If all the changes look okay, I'll PIP and validate the branch, then merge.

Copy link
Contributor

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stepps00
Copy link
Contributor Author

I'll merge this once I'm able to PIP records. Currently working through an issue indexing the records with WOF PIP tools: whosonfirst/go-whosonfirst-pgis#13

@stepps00
Copy link
Contributor Author

stepps00 commented Jun 26, 2020

Most recent commit contains the PIP work for this branch.
I'll QA a bit more, then merge if everything looks good.

@stepps00 stepps00 changed the title [WIP] Update Romania localities Update Romania localities Jun 27, 2020
@stepps00 stepps00 merged commit 78a9941 into master Jun 27, 2020
@stepps00 stepps00 deleted the stepps00/locality-updates branch June 27, 2020 00:17
@stepps00 stepps00 mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add official data for Romanian localities
2 participants