Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize html and basic responsiveness #446

Open
wants to merge 37 commits into
base: master
Choose a base branch
from

Conversation

frankystone
Copy link
Contributor

@frankystone frankystone commented Jan 15, 2025

Fixes #181 (partly)

This is not perfect yet, but it's basically working. There might be some glitches here and there… After testing on alpha this can merged, imho.

What was done so far:

  • removed the div's which were used to order the content (still has a lot of div's)
  • instead implement modern tags like <header>, <nav>, <main>, <article> and <section>
  • most of those new tags have now the property display: flex; which is easy to use and provide the responsiveness
  • i gave the headers on dark background a slightly brighter color, so Web design lacks contrast #123 is also partly fixed

The basic layout is like this now:

|----------------------- BODY -------------------------------- |
|                                                              |
| +++++++++++++++++++++ HEADER +++++++++++++++++++++++++++++++ |
| +  logo                                  right_boxes       + |
| ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ |
|                                                              |
| *********************** NAV ******************************** |
| * home | game | wiki | …                        search     * |
| ************************************************************ |
|                                                              |
| +++++++++++++++++++++++ MAIN +++++++++++++++++++++++++++++++ |
| +                                                          + |
| + *************** ARTICLE ***************  #### ASIDE #### + |
| + * ============= HEADER ============== *  # - SECTION - # + |
| + * =            welcome              = *  # -  polls  - # + |
| + * =================================== *  # ----------- # + |
| + * ------------ SECTION -------------- *  # - SECTION - # + |
| + * - widelands is a free...          - *  # -  events - # + |
| + * -                                 - *  # -         - # + |
| + * -                                 - *  # ----------- # + |
| + * -                                 - *  # - SECTION - # + |
| + * -                                 - *  # -         - # + |
| + * -                                 - *  # -  last   - # + |
| + * -                                 - *  # -  posts  - # + |
| + * -                                 - *  # -         - # + |
| + * -                                 - *  # -         - # + |
| + * -                                 - *  # ----------- # + |
| + * -                                 - *  ############### + |
| + * --------------------------------- - *                  + |
| + * ============= HEADER ============== *                  + |
| + * =              news               = *                  + |
| + * =================================== *                  + |
| + * ------------ SECTION -------------- *                  + |
| + * -              news1              - *                  + |
| + * -                                 - *                  + |
| + * -                                 - *                  + |
| + * --------------------------------- - *                  + |
| + * ------------ SECTION -------------- *                  + |
| + * -              news2              - *                  + |
| + * -                                 - *                  + |
| + * -                                 - *                  + |
| + * -                                 - *                  + |
| + * --------------------------------- - *                  + |
| + ***************************************                  + |
| +                                                          + |
| ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ |
|                                                              |
| ************************* FOOTER *************************** |
| *                        contact                           * |
| ************************************************************ |
|                                                              |
| ------------------------------------------------------------ |

For a comparison with a small viewport (left now, right this branch):
wl responsiv

Further work:

  • find a good solution for the navigation bar, maybe something like the w3c example
  • for small viewports move the aside block above the article block, so polls, events and latest posts are shown before the article content

@bunnybot
Copy link

Mirrored on Codeberg as #CB362.

@bunnybot bunnybot changed the title Modernize html and basic responsiveness WIP: Modernize html and basic responsiveness Jan 15, 2025
@bunnybot
Copy link

janusMirrored from Codeberg
On Thu Jan 16 16:57:33 CET 2025, janus wrote:


<@>bunnybot update

@bunnybot
Copy link

janusMirrored from Codeberg
On Thu Jan 16 17:39:55 CET 2025, janus wrote:


<@>bunnybot logs

@bunnybot
Copy link

janusMirrored from Codeberg
On Thu Jan 16 18:31:11 CET 2025, janus wrote:


<@>Nordfriese kannst du mal schauen wo es knirscht?

#446 auf GH

@bunnybot bunnybot changed the title WIP: Modernize html and basic responsiveness Modernize html and basic responsiveness Jan 23, 2025
@bunnybot bunnybot marked this pull request as ready for review January 23, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website responsive template
2 participants