Skip to content

Conversation

@jacklinke
Copy link

All Submissions:

Changes to / New Features:

Description of changes

Adding this field will populate the description on PyPI's search page.

Copy link
Collaborator

@iisakkirotko iisakkirotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jacklinke! First off, thanks for the PR. I think two things should be addressed before we can merge this:

  1. As you can see the build fails because description is listed under dynamic in the pyproject.toml. I don't think it needs to be there, since evidently the value doesn't get added dynamically anywhere (If I'm wrong @maartenbreddels feel free to correct me).
  2. The pyproject.toml in the project root is actually for the package solara-ui (due to how the project was evolving when we split off the solara package to solara-ui, solara-server, etc. So I think this description should go to the file found under packages/solara-meta. I think it would also be good to change this in the other packages in this repo (I think all of them have the same issue), but I understand if you feel that's out of your scope. Let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants