Feature: Airline lookup by callsign#444
Open
WeegeeNumbuh1 wants to merge 4 commits into
Open
Conversation
it works (uses the operators.js that's part of tar1090-db)
makes it so we don't have to check every time the data refreshes
pairs well with the route row
empty results now sort to the bottom and valid entries now have tooltip popups like other table entries
Owner
|
not sure when i'll have time to look at this. no worries about the PR, looks fine. This has been requested, i've been saying it's not necessary :P Wanted to use the data from Mictronics but if it's bad we can use your data and put it into tar1090-db i guess. |
Author
|
Oh yeah no rush, hopefully someone else sees this PR and tries these changes before merging. Maybe I can reach out to Mictronics about the airlines names so that tar1090-db doesn't have to change its sources, though I will mention that my airlines database might have differing naming priorities compared to what's being used now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds new airline lookup by callsign with the associated UI changes. Uses the
operators.jsfile that's already part oftar1090-dbthat gets pulled when running the install script, so no need for additional databases or files.Pics first
Adds to the infoblock and also has a tooltip with the country and telephonic name
Adds new column to the table
Also does the same tooltip thing like how the route column does it
Also available in the hoverbox thing
Disabled by default in
defaults.jsoperators.jslimitations as of this postImportant
See this comparison table.
tl;dr it needed a lot of cleanup so I'm using my own database to get cleaner looking names.
off-topic ramblings
Maybe my database can be integrated into tar1090-db? Because imho the names used in the operators file looks like a set of basic filters and formatting was only applied to the FAA file.
oof
Additional features
RPC123vs. reg =RP-C123).Known limitations and things I didn't test
defaults.jshas all the added elements to handle this featureThings that probably could be added later
Why this feature?
I got tired of seeing airline prefixes I didn't recognize and having to look them up manually in my own database, plus, I already figured out how to do callsign to airline matching with my other project, so it made sense to add the feature to tar1090. Also, I didn't see anyone else suggesting or adding a feature like this so I went ahead and did it.
Other things
First PR ever; I don't really know all the conventions with git/GitHub/branching and all that, all my own repos I just yolo it and commit to main/master lmao. Hopefully this PR is good.