Skip to content

Commit

Permalink
k8s: Remove envoy shutdown attempt from crawler.sh
Browse files Browse the repository at this point in the history
Remove the `POST /quitquitquit` shutdown signal attempt from crawler.sh.
We are now attempting to manage the sidecar container's runtime state
with a controller and annotation in the deployment.

Bug: T292861
Change-Id: Ia7a1fe0f4c2801dd07c269091903ffc57328c015
  • Loading branch information
bd808 committed Feb 19, 2025
1 parent f7d21ce commit d630f2f
Showing 1 changed file with 2 additions and 10 deletions.
12 changes: 2 additions & 10 deletions contrib/cronjob/crawler.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Copyright (c) 2021 Wikimedia Foundation and contributors.
# Copyright (c) 2025 Wikimedia Foundation and contributors.
# All Rights Reserved.
#
# This file is part of Toolhub.
Expand All @@ -19,12 +19,4 @@

set -Eeuo pipefail

# Send shutdown signal to envoy process running at 127.0.0.1:1666
# https://envoyproxy.io/docs/envoy/latest/operations/admin#post--quitquitquit
# Bug: T292861
kill_envoy() {
printf "POST /quitquitquit HTTP/1.0\r\n\r\n" >/dev/tcp/127.0.0.1/1666
}
trap 'kill_envoy' EXIT

poetry run python3 /srv/app/manage.py crawl --quiet
exec poetry run python3 /srv/app/manage.py crawl --quiet

0 comments on commit d630f2f

Please sign in to comment.