Skip to content

Implement update to specific version in the ProsperoInstallationManager (wildlfy-core req) #979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
TomasHofman wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Implement update to specific version in the ProsperoInstallationManager (wildlfy-core req) #979

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00c8f78
Implement updating to specific manifest versions in InstallationManager
TomasHofman Nov 5, 2025
9427433
Implement installation-manager findAvailableManifestVersions method
TomasHofman Dec 15, 2025
9602aa9
Improve Prospero CLI output when listing changes before updating inst…
TomasHofman Jan 29, 2026
44225d2
Rename the --version parameter for specifying manifest versions to --…
TomasHofman Jan 29, 2026
9316d70
Improve history command output, list manifest on separate lines
TomasHofman Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 59 additions & 20 deletions integration-tests/src/test/java/org/wildfly/prospero/it/cli/UpdateToVersionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,12 @@
import org.wildfly.channel.Channel;
import org.wildfly.channel.ChannelManifest;
import org.wildfly.channel.Stream;
import org.wildfly.prospero.api.InstallationMetadata;
import org.wildfly.prospero.cli.CliMessages;
import org.wildfly.prospero.cli.ReturnCodes;
import org.wildfly.prospero.cli.commands.CliConstants;
import org.wildfly.prospero.it.ExecutionUtils;
import org.wildfly.prospero.metadata.ManifestVersionRecord;
import org.wildfly.prospero.test.BuildProperties;
import org.wildfly.prospero.test.TestInstallation;
import org.wildfly.prospero.test.TestLocalRepository;
Expand All @@ -33,25 +35,26 @@ public class UpdateToVersionTest extends CliTestBase {
private TestLocalRepository testLocalRepository;
private TestInstallation testInstallation;
private Channel testChannel;
private Channel testUrlChannel;
private URL manifestUrl;
private URL manifestUrl2;

@Before
public void setUp() throws Exception {
testLocalRepository = new TestLocalRepository(temp.newFolder("local-repo").toPath(),
List.of(new URL("https://repo1.maven.org/maven2")));

prepareRequiredArtifacts(testLocalRepository);

testLocalRepository = prepareLocalRepository(temp.newFolder("local-repo").toPath());
testInstallation = new TestInstallation(temp.newFolder("server").toPath());

testLocalRepository.deploy(TestInstallation.fpBuilder("org.test:pack-one:1.0.0")
.addModule("commons-io", "commons-io", COMMONS_IO_VERSION)
.build());

testChannel = new Channel.Builder()
.setName("test-channel")
.addRepository("local-repo", testLocalRepository.getUri().toString())
.setManifestCoordinate("org.test", "test-channel")
.build();
manifestUrl = testLocalRepository.getUri().resolve("org/test/test-channel/1.0.0/test-channel-1.0.0-manifest.yaml").toURL();
manifestUrl2 = testLocalRepository.getUri().resolve("org/test/test-channel/1.0.1/test-channel-1.0.1-manifest.yaml").toURL();
testUrlChannel = new Channel.Builder()
.setName("test-channel")
.addRepository("local-repo", testLocalRepository.getUri().toString())
.setManifestUrl(manifestUrl)
.build();
}

@Test
Expand Down Expand Up @@ -108,7 +111,7 @@ public void warnIfDowngradeServerToNonLatestVersion() throws Exception {
e.assertReturnCode(ReturnCodes.SUCCESS);
assertThat(e.getCommandOutput())
.contains("The update will downgrade following channels:")
.contains(" * test-channel: 1.0.1 -> 1.0.0");
.contains(" * test-channel: 1.0.1 (Logical version 1.0.1) -> 1.0.0 (Logical version 1.0.0)");
} catch (IOException ex) {
throw new RuntimeException(ex);
}
Expand All @@ -127,7 +130,7 @@ public void rejectDowngradeServerIfVersionNotSpecified() throws Exception {

newRepo.deploy(
new DefaultArtifact("org.test", "test-channel", "manifest", "yaml","1.0.0"),
new ChannelManifest("test-manifest", null, null, List.of(
new ChannelManifest("test-manifest", "manifest-id", "Logical version 1.0.0", "description", null, List.of(
new Stream("org.wildfly.galleon-plugins", "wildfly-config-gen", GALLEON_PLUGINS_VERSION),
new Stream("org.wildfly.galleon-plugins", "wildfly-galleon-plugins", GALLEON_PLUGINS_VERSION),
new Stream("commons-io", "commons-io", COMMONS_IO_VERSION),
Expand All @@ -141,7 +144,7 @@ public void rejectDowngradeServerIfVersionNotSpecified() throws Exception {
e.assertReturnCode(ReturnCodes.PROCESSING_ERROR);
assertThat(e.getCommandOutput())
.contains("The update will downgrade following channels:")
.contains(" * test-channel: 1.0.1 -> 1.0.0");
.contains(" * test-channel: 1.0.1 (Logical version 1.0.1) -> 1.0.0");
} catch (IOException ex) {
throw new RuntimeException(ex);
}
Expand Down Expand Up @@ -178,7 +181,37 @@ public void listUpdatesToSpecificVersion() throws Exception {
.containsPattern("commons-io:commons-io\\s+2.18.0\\s+==>\\s+2.18.0.CP-01");
}

private void prepareRequiredArtifacts(TestLocalRepository localRepository) throws Exception {
@Test
public void updateUrlManifest() throws Exception {
testInstallation.install("org.test:pack-one:1.0.0", List.of(testUrlChannel));
testInstallation.verifyModuleJar("commons-io", "commons-io", COMMONS_IO_VERSION);

testInstallation.update(CliConstants.VERSION, "test-channel::" + manifestUrl2.toString());

testInstallation.verifyModuleJar("commons-io", "commons-io", bump(COMMONS_IO_VERSION));
testInstallation.verifyInstallationMetadataPresent();
try (InstallationMetadata metadata = testInstallation.readInstallationMetadata()) {
// Verify manifest url in manifest_version.yaml file is updated to manifestUrl2
assertThat(metadata.getManifestVersions()).satisfies(versionRecord -> {
assertThat(versionRecord).isPresent();
List<String> currentManifestUrls = versionRecord.get().getUrlManifests().stream()
.map(ManifestVersionRecord.UrlManifest::getUrl).toList();
assertThat(currentManifestUrls).contains(manifestUrl2.toString());
});

// Verify manifest url in installer-channels.yaml file *has not changed* - the installation is still
// subscribed to the original manifest URL.
List<URL> installedChannelsUrls = metadata.getProsperoConfig().getChannels().stream()
.map(c -> c.getManifestCoordinate().getUrl())
.toList();
assertThat(installedChannelsUrls).contains(manifestUrl);
}
}

public static TestLocalRepository prepareLocalRepository(Path repoPath) throws Exception {
TestLocalRepository localRepository = new TestLocalRepository(repoPath,
List.of(new URL("https://repo1.maven.org/maven2")));

localRepository.deployGalleonPlugins();

Artifact resolved = localRepository.resolveAndDeploy(new DefaultArtifact("commons-io", "commons-io", "jar", COMMONS_IO_VERSION));
Expand All @@ -189,33 +222,39 @@ private void prepareRequiredArtifacts(TestLocalRepository localRepository) throw
// deploy test manifests updating the commons-io in each
localRepository.deploy(
new DefaultArtifact("org.test", "test-channel", "manifest", "yaml","1.0.0"),
new ChannelManifest("test-manifest", null, null, List.of(
new ChannelManifest("test-manifest", "manifest-id", "Logical version 1.0.0", "Description", null, List.of(
new Stream("org.wildfly.galleon-plugins", "wildfly-config-gen", GALLEON_PLUGINS_VERSION),
new Stream("org.wildfly.galleon-plugins", "wildfly-galleon-plugins", GALLEON_PLUGINS_VERSION),
new Stream("commons-io", "commons-io", COMMONS_IO_VERSION),
new Stream("org.test", "pack-one", "1.0.0")
)));

testLocalRepository.deploy(
localRepository.deploy(
new DefaultArtifact("org.test", "test-channel", "manifest", "yaml","1.0.1"),
new ChannelManifest("test-manifest", null, null, List.of(
new ChannelManifest("test-manifest", "manifest-id", "Logical version 1.0.1", "Description", null, List.of(
new Stream("org.wildfly.galleon-plugins", "wildfly-config-gen", GALLEON_PLUGINS_VERSION),
new Stream("org.wildfly.galleon-plugins", "wildfly-galleon-plugins", GALLEON_PLUGINS_VERSION),
new Stream("commons-io", "commons-io", bump(COMMONS_IO_VERSION)),
new Stream("org.test", "pack-one", "1.0.0")
)));

testLocalRepository.deploy(
localRepository.deploy(
new DefaultArtifact("org.test", "test-channel", "manifest", "yaml","1.0.2"),
new ChannelManifest("test-manifest", null, null, List.of(
new ChannelManifest("test-manifest", "manifest-id", "Logical version 1.0.2", "Description", null, List.of(
new Stream("org.wildfly.galleon-plugins", "wildfly-config-gen", GALLEON_PLUGINS_VERSION),
new Stream("org.wildfly.galleon-plugins", "wildfly-galleon-plugins", GALLEON_PLUGINS_VERSION),
new Stream("commons-io", "commons-io", bump(bump(COMMONS_IO_VERSION))),
new Stream("org.test", "pack-one", "1.0.0")
)));

localRepository.deploy(TestInstallation.fpBuilder("org.test:pack-one:1.0.0")
.addModule("commons-io", "commons-io", COMMONS_IO_VERSION)
.build());

return localRepository;
}

private String bump(String version) {
private static String bump(String version) {
final Pattern pattern = Pattern.compile(".*\\.CP-(\\d{2})");
final Matcher matcher = pattern.matcher(version);
if (matcher.matches()) {
Expand Down
Loading
Loading