Skip to content

Conversation

@Isakku
Copy link

@Isakku Isakku commented Aug 14, 2018

Changed icon and scripts, testing is required.
Followed @Saroufim instructions here
#116 (comment)
I'm no expert with Wine or Flatpak, this is my first pull request here.

Changed icon and  scripts, testing is required.
@LeandroStanger
Copy link
Contributor

Add the correct icon https://us.shop.battle.net/static/3.2.1/images/family-icons/starcraft-remastered.svg

@Isakku
Copy link
Author

Isakku commented Aug 15, 2018

Add the correct icon https://us.shop.battle.net/static/3.2.1/images/family-icons/starcraft-remastered.svg

Lol, and that's the icon we are supposed to use? I really liked the Terran Wraith that SC1 had and I loved that new Wraith redesign they supplied with 1.16, but now they give us this bland SC letters... sigh OK, I'm doing it.

EDIT
Hmm. while we are at it, could you please tell me how do you test this? I mean, how do you test winepak scripts that are offline and were made by yourself with mostly possible horrific bugs without breaking your system (I already found a bug with SC2 winepak) #122
When I was editing it to make the SC1 script I noticed that it changes Wine graphics mode to opengl... I don't know why. Lutris SC2 install script does many other different things but nothing like that.

Lol, and that's the icon we are supposed to use? I really liked the Terran Wraith that SC1 had and I loved that new Wraith redesign they supplied with 1.16, but now they give us this bland SC letters... sigh OK, I'm doing it.
<metadata_license>CC0-1.0</metadata_license>
<project_license>LicenseRef-proprietary</project_license>
<name>StarCraft</name>
<summary>The Ultimate Real-time Strategy Game</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<summary>(RTS) Estrategia en tiempo real</summary>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took that text from official website. I don't see the need to change it.

<summary>The Ultimate Real-time Strategy Game</summary>
<summary xml:lang="pt_BR">Estratégia em tempo real (RTS)</summary>
<summary xml:lang="es">(RTS) Estrategia en tiempo real</summary>
<description><p>Infinite fronts, infinite enemies. Real-time Strategy Restored. Command the mechanized Terrans, psi-powered Protoss, and insectoid Zerg as they vie for map control of eight unique environments. Build your base and conscript your army in a real-time, military sci-fi vision of the future. Once you’ve finished the campaign, go head-to-head or team up with other players online. Pit StarCraft’s iconic, radically-different races against one another in the ultimate theater of war.</p></description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<description><p>StarCraft introdujo muchas características revolucionarias que se han convertido en elementos básicos del género de la estrategia en tiempo real: facciones asimétricas, equilibrio meticuloso y un fuerte énfasis en la estrategia y la accesibilidad. Descubre por qué, después de más de quince años, miles de jugadores de todo el mundo aún siguen disfrutando de la frenética acción de StarCraft.</p></description> 

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this is from official website. I don't see the need to change it.

<summary xml:lang="pt_BR">Estratégia em tempo real (RTS)</summary>
<summary xml:lang="es">(RTS) Estrategia en tiempo real</summary>
<description><p>Infinite fronts, infinite enemies. Real-time Strategy Restored. Command the mechanized Terrans, psi-powered Protoss, and insectoid Zerg as they vie for map control of eight unique environments. Build your base and conscript your army in a real-time, military sci-fi vision of the future. Once you’ve finished the campaign, go head-to-head or team up with other players online. Pit StarCraft’s iconic, radically-different races against one another in the ultimate theater of war.</p></description>
<description xml:lang="pt_BR"><p>Batalhas infinitas, inimigos infinitos.Estratégia em tempo real revitalizada. Lidere os terranos com suas máquinas mortíferas, os protoss de poderes psiônicos, e os zergs insectiformes em batalhas territoriais por oito cenários únicos. Mergulhe num futuro militarista de ficção-científica. Construa uma base e aliste o seu exército. Tudo isto numa experiência em tempo real! Terminou a campanha? Então aproveite para enfrentar ou cooperar com outros jogadores em batalhas online. Você terá o maior palco de guerra do universo à sua disposição, onde as inigualáveis raças de StarCraft se enfrentarão ao seu comando.</p></description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<description xml:lang="pt_BR"><p>StarCraft introduziu muitos recursos revolucionários que desde então se tornaram padrão no gênero de estratégia em tempo real: facções assimétricas, equilíbrio meticuloso e forte ênfase em estratégia aprofundada e alta acessibilidade. Descubra por quê, após mais de dez anos, StarCraft continua a fazer sucesso em torneios no mundo inteiro.</p></description> 

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yet again, the text is from official website.

<summary xml:lang="es">(RTS) Estrategia en tiempo real</summary>
<description><p>Infinite fronts, infinite enemies. Real-time Strategy Restored. Command the mechanized Terrans, psi-powered Protoss, and insectoid Zerg as they vie for map control of eight unique environments. Build your base and conscript your army in a real-time, military sci-fi vision of the future. Once you’ve finished the campaign, go head-to-head or team up with other players online. Pit StarCraft’s iconic, radically-different races against one another in the ultimate theater of war.</p></description>
<description xml:lang="pt_BR"><p>Batalhas infinitas, inimigos infinitos.Estratégia em tempo real revitalizada. Lidere os terranos com suas máquinas mortíferas, os protoss de poderes psiônicos, e os zergs insectiformes em batalhas territoriais por oito cenários únicos. Mergulhe num futuro militarista de ficção-científica. Construa uma base e aliste o seu exército. Tudo isto numa experiência em tempo real! Terminou a campanha? Então aproveite para enfrentar ou cooperar com outros jogadores em batalhas online. Você terá o maior palco de guerra do universo à sua disposição, onde as inigualáveis raças de StarCraft se enfrentarão ao seu comando.</p></description>
<description xml:lang="es"><p>Infinidad de frentes, infinidad de enemigos Estrategia en tiempo real renovada. Dirige a los terran mecanizados, a los protoss con energía psiónica y a los zerg insectoides en su lucha por obtener el control del mapa en ocho entornos únicos. Construye tu base y recluta a tu ejército en tiempo real en esta versión militarizada de un futuro de ciencia ficción. Cuando hayas terminado la campaña, disfruta de las batallas en línea, tanto en equipo como mano a mano contra otro jugador. Enfrenta a las razas emblemáticas y radicalmente diferentes de StarCraft en el escenario de guerra final.</p></description>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<description xml:lang="es"><p>StarCraft introdujo muchas características revolucionarias que se han convertido en elementos básicos del género de la estrategia en tiempo real: facciones asimétricas, equilibrio meticuloso y un fuerte énfasis en la estrategia y la accesibilidad. Descubre por qué, después de más de quince años, miles de jugadores de todo el mundo aún siguen disfrutando de la frenética acción de StarCraft.</p></description> 

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SIGH I don't see a point in these changes. the text comes from the official website.

@Isakku
Copy link
Author

Isakku commented Oct 24, 2018

There is really no way I can make this work if the code It is based on (StarCraft II Winepak) fails on my side (issue #122)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants