winter 1.2.8 support #57
Conversation
|
@LukeTowers I started converting this plugin but encountered an issue with the default update view breadcrumbs... it is showing "Users" twice, as can be seen in the screenshot below:
|
|
The breadcrumb can be fixed by adding this commit to the diff --git a/modules/backend/layouts/_breadcrumb.php b/modules/backend/layouts/_breadcrumb.php
index c9f575539..cc56ddfda 100644
--- a/modules/backend/layouts/_breadcrumb.php
+++ b/modules/backend/layouts/_breadcrumb.php
@@ -12,7 +12,7 @@
<?php if ($menu): ?>
<ul>
<li><a href="<?= $menu->url ?>"><?= e(trans($menu->label)) ?></a></li>
- <?php if ($sideMenu): ?>
+ <?php if ($sideMenu && $sideMenu->url !== $menu->url): ?>
<li><a href="<?= $sideMenu->url ?>"><?= e(trans($sideMenu->label)) ?></a></li>
<?php elseif ($settingsItem): ?>
<li><a href="<?= $settingsItem->url ?>"><?= e(trans($settingsItem->label)) ?></a></li> |
| /** | ||
| * @var array `RelationController` configuration, by extension. | ||
| */ | ||
| public $relationConfig; |
There was a problem hiding this comment.
This could technically be a breaking change for plugins that extend this controller without using the addDynamicProperty() approach
There was a problem hiding this comment.
See 0852e19. @firemankurt are you still using this?
There was a problem hiding this comment.
This could technically be a breaking change for plugins that extend this controller without using the addDynamicProperty() approach
Good point, I was actually thinking about this myself. I'll revert this part.
There was a problem hiding this comment.
I'm fine with only keeping the relationConfig property, the other two should be fine to get rid of.
There was a problem hiding this comment.
That might create problems with plugins we don't know about. Doesn't really hurt keeping those.
Depends on wintercms/winter#1312
Update Winter.User to use formcontroller behavior's default views.