Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: change test for build meta data #774

Merged
merged 2 commits into from
Nov 21, 2024
Merged

refactor: change test for build meta data #774

merged 2 commits into from
Nov 21, 2024

Conversation

SimonThormeyer
Copy link
Contributor

@SimonThormeyer SimonThormeyer commented Nov 21, 2024 •
edited
Loading

What's new in this PR

  • change test for build metadata to achieve closer parity with the kotlin test.

  • change fields of BuildMetadata to camelCase.

  • To comply to javascript conventions.

  • This is desirable because we expose this struct beyond our typescript wrapper.

  • It has to be this tedious way of renaming each field separately, until Automatically camelify names rustwasm/wasm-bindgen#1818 is solved.

PR Submission Checklist for internal contributors
  • The PR Title
    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@SimonThormeyer SimonThormeyer force-pushed the simon/test/change-test-for-build-meta-data branch from 0dabe78 to 1fd69b1 Compare November 21, 2024 11:50
@coriolinus
Copy link
Contributor

Makes sense and looks good so far

@SimonThormeyer SimonThormeyer marked this pull request as ready for review November 21, 2024 12:01
@SimonThormeyer SimonThormeyer requested a review from a team as a code owner November 21, 2024 12:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 21, 2024 •
edited
Loading

🐰 Bencher Report

Branchsimon/test/change-test-for-build-meta-data
Testbedubuntu-latest
Click to view all benchmark results
BenchmarkLatencynanoseconds (ns)
Commit add f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		18,487,000.00
Commit add f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		6,839,200.00
Commit add f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		9,395,000.00
Commit add f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		11,841,000.00
Commit add f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		14,478,000.00
Commit add f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		16,558,000.00
Commit add f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold		980,520,000.00
Commit add f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold		7,112,900.00
Commit add f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold		84,174,000.00
Commit add f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold		219,130,000.00
Commit add f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold		424,200,000.00
Commit add f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold		670,000,000.00
Commit pending proposals f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		115,650,000.00
Commit pending proposals f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		28,384,000.00
Commit pending proposals f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		45,958,000.00
Commit pending proposals f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		60,820,000.00
Commit pending proposals f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		78,862,000.00
Commit pending proposals f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		93,910,000.00
Commit pending proposals f(pending size)/cs1/mem/1📈 view plot
🚷 view threshold		18,107,000.00
Commit pending proposals f(pending size)/cs1/mem/101📈 view plot
🚷 view threshold		115,010,000.00
Commit pending proposals f(pending size)/cs1/mem/21📈 view plot
🚷 view threshold		36,281,000.00
Commit pending proposals f(pending size)/cs1/mem/41📈 view plot
🚷 view threshold		56,330,000.00
Commit pending proposals f(pending size)/cs1/mem/61📈 view plot
🚷 view threshold		75,034,000.00
Commit pending proposals f(pending size)/cs1/mem/81📈 view plot
🚷 view threshold		94,990,000.00
Commit remove f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		27,063,000.00
Commit remove f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		6,681,200.00
Commit remove f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		8,642,300.00
Commit remove f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		12,095,000.00
Commit remove f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		16,821,000.00
Commit remove f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		22,092,000.00
Commit remove f(number clients)/cs1/mem/1002📈 view plot
🚷 view threshold		30,083,000.00
Commit remove f(number clients)/cs1/mem/2📈 view plot
🚷 view threshold		136,730,000.00
Commit remove f(number clients)/cs1/mem/202📈 view plot
🚷 view threshold		114,890,000.00
Commit remove f(number clients)/cs1/mem/402📈 view plot
🚷 view threshold		93,334,000.00
Commit remove f(number clients)/cs1/mem/602📈 view plot
🚷 view threshold		71,658,000.00
Commit remove f(number clients)/cs1/mem/802📈 view plot
🚷 view threshold		50,751,000.00
Commit update f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		136,260,000.00
Commit update f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		6,800,600.00
Commit update f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		33,707,000.00
Commit update f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		59,339,000.00
Commit update f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		86,110,000.00
Commit update f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		111,610,000.00
Count KeyPackage/cs1/mem/1002📈 view plot
🚷 view threshold		9,951,700.00
Count KeyPackage/cs1/mem/2📈 view plot
🚷 view threshold		6,364,600.00
Count KeyPackage/cs1/mem/202📈 view plot
🚷 view threshold		6,666,100.00
Count KeyPackage/cs1/mem/402📈 view plot
🚷 view threshold		7,594,100.00
Count KeyPackage/cs1/mem/602📈 view plot
🚷 view threshold		8,882,700.00
Count KeyPackage/cs1/mem/802📈 view plot
🚷 view threshold		9,668,400.00
Create group/cs1/mem📈 view plot
🚷 view threshold		6,748,400.00
Decrypt f(msg size)/cs1/mem/10📈 view plot
🚷 view threshold		6,173,900.00
Decrypt f(msg size)/cs1/mem/10010📈 view plot
🚷 view threshold		6,394,400.00
Decrypt f(msg size)/cs1/mem/2010📈 view plot
🚷 view threshold		6,159,000.00
Decrypt f(msg size)/cs1/mem/4010📈 view plot
🚷 view threshold		6,190,200.00
Decrypt f(msg size)/cs1/mem/6010📈 view plot
🚷 view threshold		6,193,500.00
Decrypt f(msg size)/cs1/mem/8010📈 view plot
🚷 view threshold		6,197,000.00
Encrypt f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		8,983,200.00
Encrypt f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		6,392,600.00
Encrypt f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		6,661,800.00
Encrypt f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		7,753,100.00
Encrypt f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		7,708,700.00
Encrypt f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		8,567,400.00
Encrypt f(msg size)/cs1/mem/10📈 view plot
🚷 view threshold		9,101,800.00
Encrypt f(msg size)/cs1/mem/10010📈 view plot
🚷 view threshold		9,190,000.00
Encrypt f(msg size)/cs1/mem/2010📈 view plot
🚷 view threshold		8,830,500.00
Encrypt f(msg size)/cs1/mem/4010📈 view plot
🚷 view threshold		9,034,900.00
Encrypt f(msg size)/cs1/mem/6010📈 view plot
🚷 view threshold		8,831,500.00
Encrypt f(msg size)/cs1/mem/8010📈 view plot
🚷 view threshold		9,121,700.00
Generate KeyPackage f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		246,180,000.00
Generate KeyPackage f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		6,537,700.00
Generate KeyPackage f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		33,430,000.00
Generate KeyPackage f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		86,936,000.00
Generate KeyPackage f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		140,210,000.00
Generate KeyPackage f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		193,200,000.00
Join from external commit f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		241,410,000.00
Join from external commit f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		7,782,700.00
Join from external commit f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		54,502,000.00
Join from external commit f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		101,590,000.00
Join from external commit f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		148,960,000.00
Join from external commit f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		195,270,000.00
Join from welcome f(group size)/cs1/mem/1002📈 view plot
🚷 view threshold		111,300,000.00
Join from welcome f(group size)/cs1/mem/2📈 view plot
🚷 view threshold		6,930,700.00
Join from welcome f(group size)/cs1/mem/202📈 view plot
🚷 view threshold		28,004,000.00
Join from welcome f(group size)/cs1/mem/402📈 view plot
🚷 view threshold		48,781,000.00
Join from welcome f(group size)/cs1/mem/602📈 view plot
🚷 view threshold		69,718,000.00
Join from welcome f(group size)/cs1/mem/802📈 view plot
🚷 view threshold		90,503,000.00
Mls vs Proteus: add/MLS/mem/1📈 view plot
🚷 view threshold		6,791,000.00
Mls vs Proteus: add/MLS/mem/101📈 view plot
🚷 view threshold		8,137,900.00
Mls vs Proteus: add/MLS/mem/21📈 view plot
🚷 view threshold		7,060,500.00
Mls vs Proteus: add/MLS/mem/41📈 view plot
🚷 view threshold		7,318,300.00
Mls vs Proteus: add/MLS/mem/61📈 view plot
🚷 view threshold		7,662,700.00
Mls vs Proteus: add/MLS/mem/81📈 view plot
🚷 view threshold		7,932,700.00
Mls vs Proteus: add/Proteus/mem/1📈 view plot
🚷 view threshold		6,437,700.00
Mls vs Proteus: add/Proteus/mem/101📈 view plot
🚷 view threshold		44,417,000.00
Mls vs Proteus: add/Proteus/mem/21📈 view plot
🚷 view threshold		14,003,000.00
Mls vs Proteus: add/Proteus/mem/41📈 view plot
🚷 view threshold		21,747,000.00
Mls vs Proteus: add/Proteus/mem/61📈 view plot
🚷 view threshold		29,616,000.00
Mls vs Proteus: add/Proteus/mem/81📈 view plot
🚷 view threshold		36,865,000.00
Mls vs Proteus: encrypt/MLS/mem/1📈 view plot
🚷 view threshold		6,275,800.00
Mls vs Proteus: encrypt/MLS/mem/101📈 view plot
🚷 view threshold		6,850,600.00
Mls vs Proteus: encrypt/MLS/mem/21📈 view plot
🚷 view threshold		6,340,100.00
Mls vs Proteus: encrypt/MLS/mem/41📈 view plot
🚷 view threshold		6,533,600.00
Mls vs Proteus: encrypt/MLS/mem/61📈 view plot
🚷 view threshold		6,669,600.00
Mls vs Proteus: encrypt/MLS/mem/81📈 view plot
🚷 view threshold		6,731,100.00
Mls vs Proteus: encrypt/Proteus/mem/1📈 view plot
🚷 view threshold		6,160,100.00
Mls vs Proteus: encrypt/Proteus/mem/101📈 view plot
🚷 view threshold		15,616,000.00
Mls vs Proteus: encrypt/Proteus/mem/21📈 view plot
🚷 view threshold		8,278,500.00
Mls vs Proteus: encrypt/Proteus/mem/41📈 view plot
🚷 view threshold		10,305,000.00
Mls vs Proteus: encrypt/Proteus/mem/61📈 view plot
🚷 view threshold		14,598,000.00
Mls vs Proteus: encrypt/Proteus/mem/81📈 view plot
🚷 view threshold		14,171,000.00
Mls vs Proteus: remove/MLS/mem/1📈 view plot
🚷 view threshold		20,030,000.00
Mls vs Proteus: remove/MLS/mem/101📈 view plot
🚷 view threshold		8,146,800.00
Mls vs Proteus: remove/MLS/mem/21📈 view plot
🚷 view threshold		17,799,000.00
Mls vs Proteus: remove/MLS/mem/41📈 view plot
🚷 view threshold		15,556,000.00
Mls vs Proteus: remove/MLS/mem/61📈 view plot
🚷 view threshold		13,270,000.00
Mls vs Proteus: remove/MLS/mem/81📈 view plot
🚷 view threshold		10,646,000.00
Mls vs Proteus: remove/Proteus/mem/1📈 view plot
🚷 view threshold		5,963,200.00
Mls vs Proteus: remove/Proteus/mem/101📈 view plot
🚷 view threshold		7,333,200.00
Mls vs Proteus: remove/Proteus/mem/21📈 view plot
🚷 view threshold		6,385,800.00
Mls vs Proteus: remove/Proteus/mem/41📈 view plot
🚷 view threshold		6,392,400.00
Mls vs Proteus: remove/Proteus/mem/61📈 view plot
🚷 view threshold		6,920,500.00
Mls vs Proteus: remove/Proteus/mem/81📈 view plot
🚷 view threshold		7,193,600.00
Mls vs Proteus: update/MLS/mem/1📈 view plot
🚷 view threshold		6,843,500.00
Mls vs Proteus: update/MLS/mem/101📈 view plot
🚷 view threshold		20,447,000.00
Mls vs Proteus: update/MLS/mem/21📈 view plot
🚷 view threshold		9,642,700.00
Mls vs Proteus: update/MLS/mem/41📈 view plot
🚷 view threshold		12,432,000.00
Mls vs Proteus: update/MLS/mem/61📈 view plot
🚷 view threshold		15,094,000.00
Mls vs Proteus: update/MLS/mem/81📈 view plot
🚷 view threshold		17,658,000.00
Mls vs Proteus: update/Proteus/mem/1📈 view plot
🚷 view threshold		6,487,300.00
Mls vs Proteus: update/Proteus/mem/101📈 view plot
🚷 view threshold		46,126,000.00
Mls vs Proteus: update/Proteus/mem/21📈 view plot
🚷 view threshold		14,651,000.00
Mls vs Proteus: update/Proteus/mem/41📈 view plot
🚷 view threshold		22,766,000.00
Mls vs Proteus: update/Proteus/mem/61📈 view plot
🚷 view threshold		30,674,000.00
Mls vs Proteus: update/Proteus/mem/81📈 view plot
🚷 view threshold		38,601,000.00
🐰 View full continuous benchmarking report in Bencher

@SimonThormeyer
refactor(wasm): change fields of BuildMetadata to camelCase
b875c0c 
To comply to javascript conventions.
This is desirable because we expose this struct beyond our typescript wrapper.
It has to be this tedious way of renaming each field separately, until rustwasm/wasm-bindgen#1818 is solved.
@SimonThormeyer
test(wasm): change test for build metadata to achieve closer parity w…
4c9cb0a 
…ith the kotlin test
@SimonThormeyer SimonThormeyer force-pushed the simon/test/change-test-for-build-meta-data branch from 4f34bf1 to 4c9cb0a Compare November 21, 2024 12:41
@SimonThormeyer SimonThormeyer merged commit ffd4e02 into main Nov 21, 2024
24 checks passed
@SimonThormeyer SimonThormeyer deleted the simon/test/change-test-for-build-meta-data branch November 21, 2024 14:13
@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici... label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coriolinus coriolinus coriolinus approved these changes

Assignees
No one assigned
Labels
echoes: technical-roadmap/throughput More specific category, to highlight task aiming at improving the development velocity and effici...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonThormeyer @coriolinus