Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cc to 3.1.0 [WPB-16041] 🍒 #3293

Merged
merged 6 commits into from
Feb 18, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 14, 2025

TaskWPB-16041 [Android] Bump CoreCrypto to 3.1.0

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

bump cc to 3.1.0

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions github-actions bot added cherry-pick PR is cherry-picking changes from another banch type: chore 🧹 👕 size: S labels Feb 14, 2025
Copy link
Contributor Author

github-actions bot commented Feb 14, 2025

Test Results

3 520 tests  ±0   3 412 ✅ ±0   6m 1s ⏱️ -16s
  603 suites ±0     108 💤 ±0 
  603 files   ±0       0 ❌ ±0 

Results for commit 3e8a375. ± Comparison against base commit 4abd575.

♻️ This comment has been updated with latest results.

Copy link
Contributor Author

github-actions bot commented Feb 14, 2025

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 14, 2025

Datadog Report

Branch report: chore/bump-cc-to-3.1-cherry-pick
Commit report: bb7b708
Test service: kalium-jvm

✅ 0 Failed, 3412 Passed, 108 Skipped, 1m 1.44s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.68%. Comparing base (4abd575) to head (3e8a375).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3293      +/-   ##
===========================================
- Coverage    50.70%   50.68%   -0.02%     
===========================================
  Files         1611     1611              
  Lines        58119    58145      +26     
  Branches      5222     5246      +24     
===========================================
+ Hits         29467    29472       +5     
- Misses       26642    26646       +4     
- Partials      2010     2027      +17     

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abd575...3e8a375. Read the comment docs.

@MohamadJaara MohamadJaara added this pull request to the merge queue Feb 18, 2025
Merged via the queue into develop with commit 7c462ea Feb 18, 2025
22 checks passed
@MohamadJaara MohamadJaara deleted the chore/bump-cc-to-3.1-cherry-pick branch February 18, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch 👕 size: S type: chore 🧹
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants