-
Notifications
You must be signed in to change notification settings - Fork 43
feat: disable profile QR code feature flag (WPB-20230) #4285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
81e83c4
to
e31ea39
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4285 +/- ##
===========================================
+ Coverage 47.54% 47.56% +0.01%
===========================================
Files 517 517
Lines 17699 17706 +7
Branches 2907 2908 +1
===========================================
+ Hits 8415 8421 +6
- Misses 8426 8427 +1
Partials 858 858
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
e31ea39
to
73b2bf8
Compare
this is only to show the QR code, i would assume the app should not react to the deeplink in this case, otherwise if the QR is obtained another way, the app will still react to it |
I will check it |
app/src/main/kotlin/com/wire/android/ui/userprofile/common/UserProfileInfo.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! 🚀
I think we can remove a leftover feature flag used while developing 1 year ago, since this is now controlled by BE :D
60397c3
to
d90c22f
Compare
|
https://wearezeta.atlassian.net/browse/WPB-20230
What's new in this PR?
New feature flag to hide QR code on user profile page.