Skip to content

chore: update core crypto to 5.x - WPB-15886 #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 7, 2025
Merged

chore: update core crypto to 5.x - WPB-15886 #2806

merged 15 commits into from
May 7, 2025

Conversation

typfel
Copy link
Member

@typfel typfel commented Apr 4, 2025 •
edited by github-actions bot
Loading

TaskWPB-15886 [iOS] Update to CC 5.0

Issue

Update CoreCrypto to 5.1.0

Todo list

  • Tests for MLSTransport
  • E2EIVerificationStatusServiceTests doesn't compile due to missing types

Testing

Exercise all MLS features and E2EI

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@typfel typfel force-pushed the chore/core-crypto-5.x branch 3 times, most recently from b751459 to 39295be Compare April 7, 2025 15:20
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 7, 2025 •
edited
Loading

Test Results

   11 files  1 028 suites   10m 28s ⏱️
7 737 tests 7 706 ✅ 30 💤 1 ❌
7 748 runs  7 718 ✅ 30 💤 0 ❌

For more details on these failures, see this check.

Results for commit cf7fae0.

♻️ This comment has been updated with latest results.

@typfel typfel force-pushed the chore/core-crypto-5.x branch 4 times, most recently from 0112360 to f215eb6 Compare April 8, 2025 22:21
@datadog-wireapp
Copy link

datadog-wireapp bot commented Apr 8, 2025 •
edited
Loading

Datadog Report

Branch report: chore/core-crypto-5.x
Commit report: 5631de3
Test service: wire-ios-mono

✅ 0 Failed, 7718 Passed, 30 Skipped, 4m 45.15s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • testThatItDisplaysAudioMessage_55() - Wire-iOS-Tests.ConversationReplyCellTests - Last Failure

    Expand for error 
     ConversationReplyCellTests.swift:507: XCTAssertTrue failed

@netbe netbe changed the title chore: update core crypto to 5.x chore: update core crypto to 5.x - WPB-15886 Apr 9, 2025
@typfel typfel force-pushed the chore/core-crypto-5.x branch from 3d99533 to 0e959f7 Compare April 10, 2025 18:34
netbe
netbe reviewed Apr 18, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I made some small suggestions and left some questions to fully understand it.

Another point: I didn't see the batch decryption for the new sync (PullPendingUpdateEventsSync.swift:81)

jullianm
jullianm reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, left a few comments before approving

dmitrysimkin
dmitrysimkin approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@dmitrysimkin dmitrysimkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just lelf one suggestion

@typfel typfel force-pushed the chore/core-crypto-5.x branch from 0c275c0 to 0f568f9 Compare April 24, 2025 10:15
@typfel typfel force-pushed the chore/core-crypto-5.x branch 4 times, most recently from 617a0ce to 4ab0cb5 Compare April 30, 2025 09:54
@typfel typfel force-pushed the chore/core-crypto-5.x branch from 4ab0cb5 to e80165b Compare May 2, 2025 15:09
netbe
netbe approved these changes May 2, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. Note there's just one unused variable to remove

@typfel typfel force-pushed the chore/core-crypto-5.x branch 3 times, most recently from f5b2ef0 to f123644 Compare May 7, 2025 11:17
@typfel typfel force-pushed the chore/core-crypto-5.x branch from f123644 to ba9ec0b Compare May 7, 2025 13:21
@typfel typfel force-pushed the chore/core-crypto-5.x branch from ba9ec0b to 000de58 Compare May 7, 2025 13:45
@netbe netbe enabled auto-merge May 7, 2025 14:04
@netbe netbe added this pull request to the merge queue May 7, 2025
Merged via the queue into develop with commit 561e8e9 May 7, 2025
19 checks passed
@netbe netbe deleted the chore/core-crypto-5.x branch May 7, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe approved these changes

@dmitrysimkin dmitrysimkin dmitrysimkin approved these changes

@jullianm jullianm jullianm approved these changes

Assignees

@typfel typfel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@typfel @netbe @dmitrysimkin @jullianm