feat: adapt Websocket for consumable notifications - WPB-17225 #2918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et-WPB-17225 # Conflicts: # WireAPI/Sources/WireAPI/Network/PushChannel/WebSocket.swift # WireAPI/Sources/WireAPI/Network/PushChannel/WebSocketProtocol.swift
netbe
commented
May 14, 2025
| @@ -30,7 +30,8 @@ public struct UpdateEventEnvelopeV0: Decodable, ToAPIModelConvertible { | |||
| UpdateEventEnvelope( | |||
| id: id, | |||
| events: (payload ?? []).map(\.updateEvent), | |||
| isTransient: transient ?? false | |||
| isTransient: transient ?? false, | |||
| deliveryTag: nil | |||
There was a problem hiding this comment.
for old enveloppes there is no acknowledgement so no deliveryTag needed
netbe
commented
May 14, 2025
| @@ -60,22 +60,6 @@ public final class Assembly { | |||
| return service | |||
| }() | |||
|
|
|||
| private lazy var pushChannelService: some PushChannelServiceProtocol = PushChannelService( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This covers the sync part while the app is in foreground with consumable notifications.
NewIncrementalSyncdepending on the consumable-notifications capabilities which will be used under aLiveSyncProtocol. It basically create and open a webSocket where we listen to events and process them.NewPushChannelto acknowledge eventsNote also that to hide the syncbar we assume that after X seconds without receiving new events we're caught up.
Other:
Testing
Use
lichenvironment where notifications.missed event occur every 5minutes meaning the client was offline for too long and needs to perform slow sync