-
Notifications
You must be signed in to change notification settings - Fork 18
chore: remove code from WireDomain package - WPB-14598 #2945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove code from WireDomain package - WPB-14598 #2945
Conversation
…o chore/delete-wiredomainpackage-WPB-14598
Test Results 6 files 502 suites 4m 29s ⏱️ For more details on these failures, see this check. Results for commit af187e2. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @caldrian
In the current PR I'm working on I add a new target to WireDomain SPM.
Basically for the new syncing we duplicate many models from WireDomain
just for the purpose of decoding/encoding into data. This is to prevent an innocent change to something like QualifiedID such as the rename of property from breaking the decoding of stored UpdateEvents. I would like to keep these models in a separate target from the main WireDomain
target because the public API is tiny and I don't want to confuse things in that target. I can certainly move my code elsewhere but can we wait until next week before merging this PR to discuss a bit further. I don't really have time today to look into it
Reverted deleting the target. |
… chore/delete-wiredomainpackage-WPB-14598
af187e2
to
fb482cb
Compare
This reverts commit 824f9c2. # Conflicts: # WireUI/Tests/WireSettingsUITests/Account/BackupImportExport/Import/ImportBackupViewModelTest.swift # wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/ImportBackupFileArchiver.swift # wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/ImportLegacyBackupUseCase.swift # wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/SessionManager+importBackupUseCase.swift # wire-ios-sync-engine/Support/Sourcery/generated/AutoMockable.generated.swift # wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift
This reverts commit 824f9c2. # Conflicts: # WireUI/Tests/WireSettingsUITests/Account/BackupImportExport/Import/ImportBackupViewModelTest.swift # wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/ImportBackupFileArchiver.swift # wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/ImportLegacyBackupUseCase.swift # wire-ios-sync-engine/Source/Use cases/ImportBackupUseCase/SessionManager+importBackupUseCase.swift # wire-ios-sync-engine/Support/Sourcery/generated/AutoMockable.generated.swift # wire-ios/Wire-iOS/Sources/UserInterface/Settings/CellDescriptors/SettingsCellDescriptorFactory+Account.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🧹
@caldrian question: I assume we can't solely keep the Swift package and remove the Xcode project because it relies on other Xcode framework like WireDataModel and WireTransport, right? thought: My concern is that we gradually adopt Swift packages for new code, I wonder is there's a possibility to do the other way around : keep the WireDomain package, remove the Xcode framework and embed legacy frameworks into Swift packages (as binaryTarget?) that WireDomain package could use. (probably out of scope of this PR as it would require much more effort, just a thought) |
Issue
This PR removes the more or less redundant WireDomain package, but keeps the WireDomain Xcode project.
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: