Skip to content

Conversation

@jullianm
Copy link
Contributor

@jullianm jullianm commented Oct 3, 2025

TaskWPB-16311 [iOS] Integrate WireCells previews in conversation

Issue

This PR integrates WireCellsAttachmentsPreviewView component from WireMessaging into legacy code:

  • check whether the message is a multipart message and adjust conditional checking logic
  • create the multipart message cell that wraps the SwiftUI previews standalone component
  • remove TODOs and clean up code

The previews for chat bubbles simple solution will come later in another PR.

Testing

N/A

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team, caldrian and samwyndham and removed request for a team October 3, 2025 09:13
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Test Results

2 052 tests   2 025 ✅  2m 19s ⏱️
  336 suites     27 💤
    2 files        0 ❌

Results for commit a91fed1.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jullianm jullianm enabled auto-merge October 7, 2025 12:57
@jullianm jullianm added this pull request to the merge queue Oct 7, 2025
Merged via the queue into develop with commit 1e18ade Oct 7, 2025
10 checks passed
@jullianm jullianm deleted the feat/integrate-wirecells-previews-in-conversation branch October 7, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants