Skip to content

Conversation

@jullianm
Copy link
Contributor

@jullianm jullianm commented Oct 3, 2025

BugWPB-20736 [iOS] Wire cells is not enabled in some conversations where it should be

Issue

Context: A conversation with wire cells enabled shows up as disabled on iOS

Causes: When conversation view appears, the cells state of that conversation is synced to ensure it's up to date however we only perform that action when the current state is pending, not when it is disabled.
Secondly, we omitted to decode the cells_state property in api v10.

Solution: Always sync the cells state property on view appears when state is either disabled or pending and add missing decoded property cells_state in api v10.

Testing

Describe how to test.

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team, netbe and samwyndham and removed request for a team October 3, 2025 15:16
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Test Results

2 205 tests   2 178 ✅  2m 16s ⏱️
  333 suites     27 💤
    2 files        0 ❌

Results for commit b1a91ed.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Out of interest did you manage to reproduce the bug before fixing this?

@jullianm
Copy link
Contributor Author

jullianm commented Oct 6, 2025

@samwyndham fyi, I pushed another commit, we omitted to decode cells_state property in api v10, and looking at Charles DD ID when he had the issue he was on api v11 so state would always be .disabled. Let's see if both fixes resolve these issues.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm;) left a question to better understand

@jullianm jullianm enabled auto-merge October 7, 2025 13:08
@jullianm jullianm added this pull request to the merge queue Oct 7, 2025
Merged via the queue into develop with commit 3f55f94 Oct 7, 2025
10 checks passed
@jullianm jullianm deleted the fix/cells-disabled-issue branch October 7, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants