-
Notifications
You must be signed in to change notification settings - Fork 24
fix: ensure cells state is synced when disabled or pending - WPB-20736 #3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results2 205 tests 2 178 ✅ 2m 16s ⏱️ Results for commit b1a91ed. ♻️ This comment has been updated with latest results. |
samwyndham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Out of interest did you manage to reproduce the bug before fixing this?
|
@samwyndham fyi, I pushed another commit, we omitted to decode |
netbe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm;) left a question to better understand
Issue
Context: A conversation with wire cells enabled shows up as disabled on iOS
Causes: When conversation view appears, the cells state of that conversation is synced to ensure it's up to date however we only perform that action when the current state is pending, not when it is disabled.
Secondly, we omitted to decode the
cells_stateproperty in api v10.Solution: Always sync the cells state property on view appears when state is either disabled or pending and add missing decoded property
cells_statein api v10.Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: