Skip to content

Fix demo bundle deployment #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 72 commits into from
May 27, 2025
Merged

Fix demo bundle deployment #776

merged 72 commits into from
May 27, 2025

Conversation

mohitrajain
Copy link
Contributor

@mohitrajain mohitrajain commented Apr 28, 2025

Change type

  • Fix
  • Feature
  • Documentation
  • Security / Upgrade

Basic information

  • THIS CHANGE REQUIRES A DEPLOYMENT PACKAGE RELEASE
  • THIS CHANGE REQUIRES A WIRE-DOCS RELEASE

Testing

  • I ran/applied the changes myself, in a test environment.
  • The CI job attached to this repo will test it for me.

Tracking

  • I mentioned this PR in Jira, OR I mentioned the Jira ticket in this PR.
  • I mentioned this PR in one of the issues attached to one of our repositories.

Knowledge Transfer

  • An Asciinema session is attached to the Jira ticket.

Motivation

Objective

Reason

Use case

@mohitrajain mohitrajain requested review from julialongtin and a team as code owners April 28, 2025 11:55
@mohitrajain mohitrajain changed the title Fix min deployment Fix demo bundle deployment Apr 28, 2025
…oy_charts to have uniform deployment, added more functions for calling_services and cert_manager
…s.example.yaml file, made it more precise based on yaml ops, add helm installation block
… access on ctr socket and allow waiting check
…ed in setup-offline-sources, couldn't use all targets which override ssh proxy vars ansible_ssh_common_args
…to offer just the functions from external use
…etween task blocks, add wait log on long running tasks, add dynamic inventory and enable ssh proxy for them, import playbooks to break setup_assets.sh and offline_deploy_k8s into smaller tasks
…s and containers-system are taken care of by minikube
…-sources and import its tasks directly in main vm-setup.yml to avoid setting up non-required archieves
…ble_ssh_private_key_file, UserKnownHostsFile while managing ssh connection, refractor verify_wire_ip and clean temp directory
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

# requirements
# ubuntu 24.04
# amd64 architecture
# Following ports to be available on it from stack-it guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Following ports to be available on it from stack-it guide
# The list of ports in the stack-it guide must be available.

# amd64 architecture
# Following ports to be available on it from stack-it guide

# it should have all dns records configured as per DNS requirements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# it should have all dns records configured as per DNS requirements
#you should have all of the dns records of the given domain configured as per the DNS requirements at:

# https://docs.wire.com/latest/how-to/install/includes/helm_dns-ingress-troubleshooting.inc.html
target_domain: "example.com"

# define this variable in case, deploying it in a private network
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# define this variable in case, deploying it in a private network
# define this variable in case you are deploying wire on a private network, for local users only.


# define this variable in case, deploying it in a private network
# specify the external (Gateway) IP of the network where the deploy_node is present
# by default, public ip address attached to the node will be used, if accessible over test_port in verify_wire_ip playbook
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# by default, public ip address attached to the node will be used, if accessible over test_port in verify_wire_ip playbook
# by default, the public ip address attached directly to the target will be used, if it is accessible over test_port in verify_wire_ip playbook

@julialongtin julialongtin merged commit 707425b into master May 27, 2025
1 of 2 checks passed
@julialongtin julialongtin deleted the fix-min-deployment branch May 27, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants