Skip to content

[WPB-18443] robustness against rabbitmq outage (follow up) #4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: WPB-18443-robustness-against-rabbitmq-outage
Choose a base branch
from
Draft

[WPB-18443] robustness against rabbitmq outage (follow up) #4651

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions services/background-worker/src/Wire/BackendDeadUserNotificationWatcher.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ getLastDeathQueue Nothing = Nothing

-- FUTUREWORK: what happens if messages expire _after_ we checked against cassandra here?
-- Should we have an async notification terminate this?
-- TODO: document this function *much* better. explain the general idea.
startConsumer :: Q.Channel -> AppT IO Q.ConsumerTag
startConsumer chan = do
env <- ask
Expand Down
1 change: 1 addition & 0 deletions services/background-worker/src/Wire/BackendNotificationPusher.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,7 @@ getRemoteDomains adminClient = do
type WorkerResult = (IORef (Maybe Q.Channel), IORef (Map Domain (Q.ConsumerTag, MVar ())))

-- FUTUREWORK: rework this in the vein of DeadLetterWatcher
-- TODO: document this function *much* better. explain the general idea.
startWorker :: AmqpEndpoint -> AppT IO WorkerResult
startWorker rabbitmqOpts = do
env <- ask
Expand Down