-
Notifications
You must be signed in to change notification settings - Fork 334
WPB-20728 background job for user group to channel association #4797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
battermann
wants to merge
75
commits into
develop
Choose a base branch
from
WPB-20728-background-job-for-user-group-to-channel-association
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
387347c
job types
battermann f4134f4
job consumer scaffold
battermann 931e26f
implement basic handler for jobs
battermann 2d120d2
clean up
battermann 3084ca9
refactor: some clean ups
blackheaven 1be2fa3
feat: add jobs defiinitions, fix schema and validate settings
blackheaven 262ce26
feat: add Effect and Interpreters
blackheaven 6141666
update cabal and nix dependencies
battermann acd4e4a
moved and removed some code
battermann 97d6f9b
background job runner
battermann 8d23abb
split job publisher and runner
battermann 30a360d
interpret job runner from background worker
battermann 8153b76
config maps, helm charts, default values, docs
battermann 70f1d4d
reduce invalid message sleep
battermann e286b66
fix linting issue
battermann 81615ca
fix arbitrary instance of request id
battermann aaa8932
wip
battermann c972c4d
fix warnings in background worker tests
battermann 82c625d
implement sync user group job
battermann 1a83dea
fix: rebase
blackheaven e14dfff
feat: call the jobs, run the jobs, add config options
blackheaven 3238023
fix: hlint
blackheaven b471420
fix: nix files
blackheaven 73c6b70
fix: config in yamls
blackheaven 34210a9
refactor: move publish from wire-api to wire-subsystem
blackheaven 0c88c20
fix: k8s configs
blackheaven 5b15a08
fix: k8s configs
blackheaven 5a57a86
fix: k8s configs
blackheaven 4c7f723
fix: k8s config
battermann 6840b54
refactor
battermann 0ca391f
missing wiring of postgres config in background-worker
battermann dd2cfae
removed todos
battermann 2362a08
configure brig cassandra client for background worker
battermann 6a049ec
fix testTemporaryQueuesAreDeletedAfterUse test
battermann b43a911
wip: debugging bg jobs
battermann d4c7be3
fix: backgroung timeout second translation
blackheaven e19d1da
fix: integration tests background-worker postgresql params
blackheaven 2ecf80d
fix fetching the channels for a group
battermann a12d128
fix: enable user-group synced tests
blackheaven 0ae5d85
add test
blackheaven dca5772
chore: rebase
blackheaven 6c9bf8d
fix: opts domain injection
blackheaven 6cfff55
use postgresql pool in background worker
battermann 30e7d81
remove redundant test
battermann f67eb0b
extend test
battermann fa0ab91
wip: galley internal route
battermann 395e796
add undefined handler in galley
battermann 0c98fc1
move BackendNotificationQueueAccess to subsystems
battermann 4b225a4
remove galley api access from background jobs
battermann 44c3c9b
moved service store to wire subsystems
battermann f4ffd3e
move FireAndForget to subsystems
battermann a0ce560
move ExternalAccess to subsystems
battermann 1311c9f
add members in background job using conv subsys
battermann d11d961
configs, helm charts, config maps etc.
battermann fa5711d
wip: moving notifConversationAction to subsystems
battermann 2b6a28f
move notify conv action to new module
battermann 9497e18
use conv subsystem in galley and fix deps in brig
battermann 24718d4
implement notifications in bg job
battermann 11e2e33
wip
battermann 9d93746
little fixes
battermann 7f91a3b
fix test
battermann 36864bf
add brig and gundeck to configmap
battermann a5746a1
changelog
battermann dd1a812
clean up
battermann 84e31d7
split AMQP channel responsiblity and make explicit by better naming
battermann 47446e4
get only channels for better performance and remove todo
battermann c327896
comment
battermann 82daaa6
move HasCellsState and helper functions
battermann aa0f347
expect roles not to be overwritten
battermann 39b9089
release notes
battermann 4089327
added comment about brig access in bg worker
battermann a9b29f5
updated comment
battermann 4c5fdd0
gen nix packages
battermann 9f13e4e
remove unimplemented endpoint
battermann 0a3febe
use random effect
battermann File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| Background-worker configuration: required values when supplying your own Helm values | ||
|
|
||
| Add the following fields under `background-worker`: | ||
|
|
||
| - `config.domain` | ||
| - `config.postgresql` | ||
| - `config.cassandraBrig` | ||
| - `config.cassandraGalley` | ||
| - `secrets.pgPassword` | ||
|
|
||
| Notes | ||
| - `config.cassandra` (for gundeck) already exists; no change needed. | ||
| - `config.backgroundJobs` and `config.postgresqlPool` have defaults; override only if needed. | ||
| - `config.postgresMigration.conversation` defaults to `postgresql`; change only if migrating conversations to PostgreSQL. | ||
| - `config.brig` and `config.gundeck` endpoints have in-cluster defaults; override only if your service DNS/ports differ. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add users of user groups to a channel in asynchronous background worker job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,21 @@ | ||
| Note that background-worker depends on some provisioned storage, namely: | ||
| Note that background-worker depends on some provisioned storage/services, namely: | ||
|
|
||
| - rabbitmq | ||
| - postgresql | ||
| - cassandra (three clusters) | ||
|
|
||
| PostgreSQL configuration | ||
| - Set connection parameters under `config.postgresql` (libpq keywords: `host`, `port`, `user`, `dbname`, etc.). | ||
| - Provide the password via `secrets.pgPassword`; it is mounted at `/etc/wire/background-worker/secrets/pgPassword` and referenced from the configmap. | ||
|
|
||
| Cassandra configuration | ||
| - Background-worker connects to three Cassandra clusters: | ||
| - `config.cassandra` (keyspace: `gundeck`) for the dead user notification watcher. | ||
| - `config.cassandraBrig` (keyspace: `brig`) for the user store. | ||
| - `config.cassandraGalley` (keyspace: `galley`) for conversation-related data access. | ||
| - TLS may be configured via either a reference (`tlsCaSecretRef`) or inline CA (`tlsCa`) for each cluster. Secrets mount under: | ||
| - `/etc/wire/background-worker/cassandra-gundeck` | ||
| - `/etc/wire/background-worker/cassandra-brig` | ||
| - `/etc/wire/background-worker/cassandra-galley` | ||
|
|
||
| These are dealt with independently from this chart. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this something we want to define per job type? deleting users takes less time than scanning a huge table for inconsistencies.
i have little context, though. maybe i'm thinking ahead to far.