Skip to content

Conversation

fisco-unimatic
Copy link

The GrpcHttpServerFactory passes the configured notifier into the GrpcFilter.
The GrpcFilter stores that as a new field, and then passes it on to the handlers that it builds.
The handlers also store the notifier as a new field, and then set the it in the LocalNotifier thread-local before invoking stubRequestHandler.handle.

References

Issue#38 verbose console output

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • [ x] The PR request is well described and justified, including the body and the references
  • [x ] The PR title represents the desired changelog entry
  • [x ] The repository's code style is followed (see the contributing guide)
  • [x ] Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

fisco-unimatic and others added 3 commits May 31, 2024 17:45
# Conflicts:
#	src/main/java/org/wiremock/grpc/internal/ClientStreamingServerCallHandler.java
#	src/main/java/org/wiremock/grpc/internal/GrpcFilter.java
#	src/main/java/org/wiremock/grpc/internal/GrpcHttpServerFactory.java
#	src/main/java/org/wiremock/grpc/internal/UnaryServerCallHandler.java
#	src/test/java/org/wiremock/grpc/GrpcAcceptanceTest.java
@bbagameri
Copy link

I think the issue I opened may be related to this: #155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants